Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: Source/core/scripts/make_names.pl

Issue 21437003: Remove the pointer from StringImpl (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Now with placement new Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/scripts/StaticString.pm ('k') | Source/wtf/text/StringImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/scripts/make_names.pl
diff --git a/Source/core/scripts/make_names.pl b/Source/core/scripts/make_names.pl
index 4a93c848755e6f67d3e9212ff41478b0ee820c20..38fef2b836cc4df3fef10e27895522d1579bbb58 100755
--- a/Source/core/scripts/make_names.pl
+++ b/Source/core/scripts/make_names.pl
@@ -621,7 +621,7 @@ sub printNamesCppFile
print F "DEFINE_GLOBAL(AtomicString, ${lowerNamespace}NamespaceURI)\n\n";
- print F StaticString::GenerateStrings(\%allStrings);
+ print F StaticString::GenerateStringDecls(\%allStrings);
if (keys %allTags) {
print F "// Tags\n";
@@ -661,7 +661,7 @@ sub printNamesCppFile
print(F " // Namespace\n");
print(F " new ((void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n");
print(F "\n");
- print F StaticString::GenerateStringAsserts(\%allStrings);
+ print F StaticString::GenerateStringImpls(\%allStrings);
if (keys %allTags) {
my $tagsNamespace = $parameters{tagsNullNamespace} ? "nullAtom" : "${lowerNamespace}NS";
@@ -1265,7 +1265,7 @@ sub createGenericNamesFile
printLicenseHeader($F);
printCppHead($F, $basePrefix, $baseName, "WTF");
- print F StaticString::GenerateStrings(\%parameters);
+ print F StaticString::GenerateStringDecls(\%parameters);
while ( my ($name, $identifier) = each %parameters ) {
print F "DEFINE_GLOBAL(AtomicString, $name)\n";
@@ -1274,7 +1274,7 @@ sub createGenericNamesFile
printInit($F, 0);
print F "\n";
- print F StaticString::GenerateStringAsserts(\%parameters);
+ print F StaticString::GenerateStringImpls(\%parameters);
while ( my ($name, $identifier) = each %parameters ) {
print F " new ((void*)&$name) AtomicString(${name}Impl);\n";
@@ -1284,4 +1284,3 @@ sub createGenericNamesFile
close F;
exit 0;
}
-
« no previous file with comments | « Source/core/scripts/StaticString.pm ('k') | Source/wtf/text/StringImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698