Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2143563002: net: Remove URLRequestContextBuilder::HttpCacheParams::Type (Closed)

Created:
4 years, 5 months ago by hajimehoshi
Modified:
4 years, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Remove URLRequestContextBuilder::HttpCacheParams::Type Since only Type::IN_MEMORY is currently used, this CL removes that enum to improve code health. BUG=n/a TEST=n/a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -30 lines) Patch
M net/url_request/url_request_context_builder.h View 1 chunk +0 lines, -15 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +3 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 739793003 Patch 60001

Messages

Total messages: 6 (2 generated)
hajimehoshi
PTAL
4 years, 5 months ago (2016-07-12 06:09:19 UTC) #2
hajimehoshi
On 2016/07/12 06:09:19, hajimehoshi wrote: > PTAL Seems like that enum is currently used. Let ...
4 years, 5 months ago (2016-07-12 06:14:43 UTC) #3
mmenke
On 2016/07/12 06:14:43, hajimehoshi wrote: > On 2016/07/12 06:09:19, hajimehoshi wrote: > > PTAL > ...
4 years, 5 months ago (2016-07-12 13:13:19 UTC) #5
mmenke
4 years, 5 months ago (2016-07-12 13:14:01 UTC) #6
Message was sent while issue was closed. 
On 2016/07/12 13:13:19, mmenke wrote:
> On 2016/07/12 06:14:43, hajimehoshi wrote:
> > On 2016/07/12 06:09:19, hajimehoshi wrote:
> > > PTAL
> > 
> > Seems like that enum is currently used. Let me close this. Sorry for the
> > confusion.
> 
> NOT LGTM.
> 
>
https://cs.chromium.org/chromium/src/components/cronet/url_request_context_co...

Oops - missed your last message.

Powered by Google App Engine
This is Rietveld 408576698