Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2878)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

Issue 2143203002: 🎨 Tidy up of TabPersistentStore's clean-up logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix incognito tabs persisting when cct service is active Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java
index 549522b06076f7a527584683603bbe73ff11f7f0..587bd5d96161321d40e265056cb12f0395715a9d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java
@@ -7,23 +7,18 @@ package org.chromium.chrome.browser.compositor.layouts.content;
import android.content.Context;
import android.graphics.Bitmap;
import android.graphics.Canvas;
-import android.os.AsyncTask;
import android.util.SparseArray;
import android.view.View;
import org.chromium.base.CommandLine;
-import org.chromium.base.PathUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.NativePage;
import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.chrome.browser.tabmodel.TabModelSelector;
-import org.chromium.chrome.browser.tabmodel.TabModelUtils;
import org.chromium.ui.base.DeviceFormFactor;
-import java.io.File;
import java.util.ArrayList;
import java.util.List;
@@ -312,43 +307,6 @@ public class TabContentManager {
}
}
- /**
- * Remove on-disk thumbnails that are no longer needed.
- * @param modelSelector The selector that answers whether a tab is currently present.
- */
- public void cleanUpPersistentData(final TabModelSelector modelSelector) {
- if (mNativeTabContentManager == 0) return;
-
- // BUG: We support multiple tab model selectors, and they all share the same thumbnail
- // directory. This cleanup code checks only the current model selector to see if the
- // thumbnails are no longer used. It should instead consult with *all* tab model selectors
- // (which may not even be in memory).
- new AsyncTask<Void, Void, String[]>() {
- @Override
- protected String[] doInBackground(Void... voids) {
- String thumbnailDirectory = PathUtils.getThumbnailCacheDirectory(mContext);
- return new File(thumbnailDirectory).list();
- }
-
- @Override
- protected void onPostExecute(String[] fileNames) {
- if (fileNames == null) return;
- for (String fileName : fileNames) {
- try {
- int id = Integer.parseInt(fileName);
- if (TabModelUtils.getTabById(modelSelector.getModel(false), id) == null
- && TabModelUtils.getTabById(modelSelector.getModel(true), id)
- == null) {
- removeTabThumbnail(id);
- }
- } catch (NumberFormatException expected) {
- // This is an unknown file name, we'll leave it there.
- }
- }
- }
- }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
- }
-
@CalledByNative
protected void notifyListenersOfThumbnailChange(int tabId) {
for (ThumbnailChangeListener listener : mListeners) {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698