Issue 21405003: [android] Clear content_browsertests profile after each run.

Issue 21405003: [android] Clear content_browsertests profile after each run. (Closed)

Created:
7 years, 4 months ago by craigdh

Modified:
7 years, 4 months ago

Reviewers:
frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Clear content_browsertests profile after each run. BUG=262175 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215392

Patch Set 2 : addressed comments #

Total comments: 2

Patch Set 3 : added comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/android/pylib/gtest/test_runner.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

frankf

https://codereview.chromium.org/21405003/diff/1/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/21405003/diff/1/build/android/pylib/gtest/test_runner.py#newcode186 build/android/pylib/gtest/test_runner.py:186: self.adb.RunShellCommand('rm -r /sdcard/content_shell', timeout_time=60 * 2) As a follow ...

7 years, 4 months ago (2013-07-31 22:12:30 UTC) #2

craigdh

7 years, 4 months ago (2013-07-31 22:49:04 UTC) #3

frankf

lgtm https://codereview.chromium.org/21405003/diff/7001/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/21405003/diff/7001/build/android/pylib/gtest/test_runner.py#newcode191 build/android/pylib/gtest/test_runner.py:191: os.path.join(self.adb.GetExternalStorage(), 'content_shell'), nit: sometimes we use '/', sometimes ...

7 years, 4 months ago (2013-07-31 23:57:18 UTC) #4

frankf

https://codereview.chromium.org/21405003/diff/7001/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (right): https://codereview.chromium.org/21405003/diff/7001/build/android/pylib/gtest/test_runner.py#newcode190 build/android/pylib/gtest/test_runner.py:190: self.adb.RunShellCommand('rm -r ' + Also let's add a comment ...

7 years, 4 months ago (2013-08-01 00:07:10 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/21405003/15001

7 years, 4 months ago (2013-08-02 22:18:48 UTC) #6

Message was sent while issue was closed.

Change committed as 215392

Expand Messages | Collapse Messages