Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2139493002: Move Ash-specific vector icon files into a separate directory (Closed)

Created:
4 years, 5 months ago by tdanderson
Modified:
4 years, 4 months ago
Reviewers:
brettw, Evan Stade
CC:
chromium-reviews, sadrul, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Ash-specific vector icon files into a separate directory Move all of the Ash-specific .icon files from ui/gfx/vector_icons into their own subdirectory ui/gfx/vector_icons/ash. BUG=626786 TEST=manual

Patch Set 1 #

Patch Set 2 : add is_chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1289 lines) Patch
M ui/gfx/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_applist.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_applist.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_keyboard.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_keyboard.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_notifications.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_notifications.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_overflow.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_overflow.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_overview.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/shelf_overview.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_menu_accessibility.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_menu_caps_lock.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_menu_rotation_lock_auto.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_menu_rotation_lock_locked.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_menu_sms.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_accessibility.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_accessibility.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_alert.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_alert.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_bolt.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_bolt.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_unreliable.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_unreliable.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_battery_x.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_caps_lock.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_caps_lock.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_rotation_lock_locked.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_rotation_lock_locked.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_update.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_update.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_volume_mute.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/system_tray_volume_mute.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_back.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_back.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_close.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_close.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_left_snapped.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_left_snapped.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_maximize.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_maximize.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_minimize.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_minimize.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_restore.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_restore.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_right_snapped.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/vector_icons/ash/window_control_right_snapped.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/gfx/vector_icons/shelf_applist.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/shelf_applist.1x.icon View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/gfx/vector_icons/shelf_keyboard.icon View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/gfx/vector_icons/shelf_keyboard.1x.icon View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/gfx/vector_icons/shelf_notifications.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/shelf_notifications.1x.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overflow.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overflow.1x.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overview.icon View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/vector_icons/shelf_overview.1x.icon View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/vector_icons/system_menu_accessibility.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/system_menu_caps_lock.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/system_menu_rotation_lock_auto.icon View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/vector_icons/system_menu_rotation_lock_locked.icon View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/gfx/vector_icons/system_menu_sms.icon View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_accessibility.icon View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_accessibility.1x.icon View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery.1x.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_alert.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_alert.1x.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_bolt.icon View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_bolt.1x.icon View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_unreliable.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_unreliable.1x.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_x.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_battery_x.1x.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_caps_lock.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_caps_lock.1x.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_rotation_lock_locked.icon View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_rotation_lock_locked.1x.icon View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_update.icon View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_update.1x.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_volume_mute.icon View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/gfx/vector_icons/system_tray_volume_mute.1x.icon View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/gfx/vector_icons/window_control_back.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/gfx/vector_icons/window_control_back.1x.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/vector_icons/window_control_close.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/window_control_close.1x.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/window_control_left_snapped.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/gfx/vector_icons/window_control_left_snapped.1x.icon View 1 chunk +0 lines, -15 lines 0 comments Download
D ui/gfx/vector_icons/window_control_maximize.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/vector_icons/window_control_maximize.1x.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/vector_icons/window_control_minimize.icon View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/gfx/vector_icons/window_control_minimize.1x.icon View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/gfx/vector_icons/window_control_restore.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/window_control_restore.1x.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/vector_icons/window_control_right_snapped.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/gfx/vector_icons/window_control_right_snapped.1x.icon View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/gfx/vector_icons_sources.gypi View 1 3 chunks +51 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
tdanderson
Brett and Evan, can you please take a look? (Evan, I have also updated the ...
4 years, 5 months ago (2016-07-09 22:24:15 UTC) #2
Evan Stade
build failures look relevant
4 years, 5 months ago (2016-07-11 15:41:30 UTC) #3
tdanderson
4 years, 4 months ago (2016-08-19 21:26:49 UTC) #8
On 2016/07/11 15:41:30, Evan Stade wrote:
> build failures look relevant

This won't work. See new WIP at https://codereview.chromium.org/2251643011/.

Powered by Google App Engine
This is Rietveld 408576698