net/dns/dns_client.cc - Issue 21368005: Detect domain-specific resolvers on OS X and disable DnsClient in such cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_client.cc

Issue 21368005: Detect domain-specific resolvers on OS X and disable DnsClient in such cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: responded to review Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_client.cc

diff --git a/net/dns/dns_client.cc b/net/dns/dns_client.cc

index 976f1533905112d21097fff65187eafc973e1224..9e29ca4265d0a5c2332cbfcb0e371bc5d222f56c 100644

--- a/net/dns/dns_client.cc

+++ b/net/dns/dns_client.cc

@@ -27,7 +27,7 @@ class DnsClientImpl : public DnsClient {

virtual void SetConfig(const DnsConfig& config) OVERRIDE {

factory_.reset();

session_ = NULL;

- if (config.IsValid()) {

+ if (config.IsValid() && !config.unhandled_options) {

ClientSocketFactory* factory = ClientSocketFactory::GetDefaultFactory();

scoped_ptr<DnsSocketPool> socket_pool(

config.randomize_ports ? DnsSocketPool::CreateDefault(factory)

« no previous file with comments | « net/dns/dns_client.h ('k') | net/dns/dns_config_service.h » ('j') | no next file with comments »