Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 21358002: Fix SHL when shift amount is zero for arm and mips. (Closed)

Created:
7 years, 4 months ago by ulan
Modified:
7 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Fix SHL when shift amount is zero for arm and mips. BUG=v8:2817 R=titzer@chromium.org TEST=octane Committed: https://code.google.com/p/v8/source/detail?r=15987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 4 months ago (2013-07-31 12:33:33 UTC) #1
titzer
lgtm
7 years, 4 months ago (2013-07-31 12:34:57 UTC) #2
ulan
7 years, 4 months ago (2013-07-31 12:46:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698