Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 21353004: Use Skia for font selection on windows (Closed)

Created:
7 years, 4 months ago by eae
Modified:
7 years, 4 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, dglazkov+blink, Rik, Stephen Chennney, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use Skia for font selection on windows Changes windows to use Skia (instead of GDI directly) for font selection and fallback handling on windows. Only applies if the GDI_FONTS_ON_WINDOWS flag is unset. BUG=249099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156339

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -21 lines) Patch
M Source/core/core.gyp View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/graphics/FontCache.h View 1 2 3 4 5 6 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp View 1 2 3 4 5 6 4 chunks +22 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkia.cpp View 1 2 3 4 5 6 5 chunks +21 lines, -16 lines 0 comments Download
A Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp View 1 2 3 4 5 6 1 chunk +190 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eae
This is working in progress and obviously not ready for review yet. It currently compiles ...
7 years, 4 months ago (2013-07-31 21:07:44 UTC) #1
eae
Ready for review. There are still some issues with the text size for complext text ...
7 years, 4 months ago (2013-08-15 21:52:08 UTC) #2
bungeman-chromium
https://codereview.chromium.org/21353004/diff/16001/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp File Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp (right): https://codereview.chromium.org/21353004/diff/16001/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp#newcode197 Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:197: HFONT hFont = CreateFontIndirect(&logFont); When Skia hands back the ...
7 years, 4 months ago (2013-08-15 22:24:44 UTC) #3
eae
https://codereview.chromium.org/21353004/diff/16001/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp File Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp (right): https://codereview.chromium.org/21353004/diff/16001/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp#newcode197 Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:197: HFONT hFont = CreateFontIndirect(&logFont); On 2013/08/15 22:24:44, bungeman2 wrote: ...
7 years, 4 months ago (2013-08-15 22:34:49 UTC) #4
eae
Please take another look. As we talked about earlier your suggestion to set the lfHeight ...
7 years, 4 months ago (2013-08-19 19:41:45 UTC) #5
bungeman-skia
lgtm
7 years, 4 months ago (2013-08-19 19:44:28 UTC) #6
bungeman-chromium
lgtm, but note that my lgtm probably doesn't carry real weight (I think I'm provisional ...
7 years, 4 months ago (2013-08-19 19:46:28 UTC) #7
eae
On 2013/08/19 19:46:28, bungeman2 wrote: > lgtm, but note that my lgtm probably doesn't carry ...
7 years, 4 months ago (2013-08-19 19:47:25 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-19 20:40:05 UTC) #9
pdr.
On 2013/08/19 20:40:05, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 4 months ago (2013-08-19 20:40:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/21353004/29001
7 years, 4 months ago (2013-08-19 20:42:46 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 22:04:47 UTC) #12
Message was sent while issue was closed.
Change committed as 156339

Powered by Google App Engine
This is Rietveld 408576698