Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21344002: Move native_app_window code to apps areas (Closed)

Created:
7 years, 4 months ago by benwells
Modified:
7 years, 4 months ago
Reviewers:
tapted, Yoyo Zhou, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, Raman Kakilate, jeremya+watch_chromium.org, sadrul, ben+watch_chromium.org, benquan, tfarina, ahutter, scheib+watch_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, chromium-apps-reviews_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Move native_app_window code to apps areas native_app_window.h -> apps component platform specific implementations of this are now in c/b/ui/xxx/apps. The platform specific implementations should also move to apps/ but they would currently bring some unwanted dependencies with them; that can happen later. BUG=159366 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215753 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215799

Patch Set 1 #

Patch Set 2 : Test compile failure #

Patch Set 3 : Fix mac and views compile #

Patch Set 4 : ChromeOS and Mac compile #

Patch Set 5 : Rebase #

Patch Set 6 : Aaaarrrrggggh #

Patch Set 7 : Fix merge error #

Total comments: 8

Patch Set 8 : First round of feedback #

Patch Set 9 : Rebase to after mac app shim fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -2941 lines) Patch
M apps/DEPS View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M apps/app_window_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/apps.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A + apps/native_app_window.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -8 lines 0 comments Download
M apps/shell_window.h View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -1 line 0 comments Download
M apps/shell_window.cc View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/shell_window_registry.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_shell_window_delegate.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/apps/chrome_shell_window_delegate.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/ui/cocoa/apps/chrome_shell_window_delegate_cocoa.mm View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 2 3 4 5 6 7 2 chunks +1 line, -8 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h View 1 2 3 4 1 chunk +0 lines, -194 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 1 chunk +0 lines, -851 lines 0 comments Download
D chrome/browser/ui/extensions/native_app_window.h View 1 chunk +0 lines, -56 lines 0 comments Download
A chrome/browser/ui/gtk/apps/chrome_shell_window_delegate_gtk.cc View 4 5 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/browser/ui/gtk/apps/native_app_window_gtk.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/gtk/apps/native_app_window_gtk.cc View 2 chunks +1 line, -8 lines 0 comments Download
D chrome/browser/ui/gtk/extensions/native_app_window_gtk.h View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc View 1 chunk +0 lines, -629 lines 0 comments Download
A chrome/browser/ui/views/apps/chrome_shell_window_delegate_views.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/browser/ui/views/apps/native_app_window_views.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -10 lines 0 comments Download
D chrome/browser/ui/views/extensions/native_app_window_views.h View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/ui/views/extensions/native_app_window_views.cc View 1 chunk +0 lines, -757 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 7 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
benwells
Will get more owners reviews once local review is good.
7 years, 4 months ago (2013-08-01 05:56:47 UTC) #1
tapted
lgtm - just some nits https://codereview.chromium.org/21344002/diff/31001/apps/native_app_window.h File apps/native_app_window.h (right): https://codereview.chromium.org/21344002/diff/31001/apps/native_app_window.h#newcode53 apps/native_app_window.h:53: } // namespace nit: ...
7 years, 4 months ago (2013-08-01 07:18:59 UTC) #2
benwells
+yoz for chrome/browser/extensions changes +sky for the rest of chrome/ apps and chrome/browser/apps is already ...
7 years, 4 months ago (2013-08-01 08:19:38 UTC) #3
Yoyo Zhou
chrome/browsers/extensions LGTM
7 years, 4 months ago (2013-08-01 19:04:48 UTC) #4
benwells
ping sky, this is not as bad as it looks. lots of files but very ...
7 years, 4 months ago (2013-08-01 22:48:56 UTC) #5
sky
LGTM
7 years, 4 months ago (2013-08-05 15:46:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/21344002/42001
7 years, 4 months ago (2013-08-05 22:35:07 UTC) #7
commit-bot: I haz the power
Change committed as 215753
7 years, 4 months ago (2013-08-06 01:18:22 UTC) #8
benwells
Reverted as it conflicted with another patch that needed to be reverted. Relanding now....
7 years, 4 months ago (2013-08-06 04:36:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/21344002/42001
7 years, 4 months ago (2013-08-06 04:37:38 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 05:33:08 UTC) #11
Message was sent while issue was closed. 
Change committed as 215799

Powered by Google App Engine
This is Rietveld 408576698