Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 213413005: Ensure RenderViewHost is not shut down until a screenshot of the page is taken. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing some unit tests. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index 8aef8e532a81e989d0f32093bc8d7f709e020e8a..62e362045dfcb8cfd4a5273f98d4658ed98947e6 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -231,6 +231,16 @@ class CONTENT_EXPORT RenderViewHostImpl
const WebPreferences& prefs) OVERRIDE;
virtual void GetAudioOutputControllers(
const GetAudioOutputControllersCallback& callback) const OVERRIDE;
+ virtual void CopyFromBackingStore(
+ const gfx::Rect& src_rect,
+ const gfx::Size& accelerated_dst_size,
+ const base::Callback<void(bool, const SkBitmap&)>& callback,
+ const SkBitmap::Config& bitmap_config) OVERRIDE;
+
+ void CopyFromBackingStoreCallback(
nasko 2014/03/26 22:48:27 This isn't a RenderViewHost method override, so it
mfomitchev 2014/03/27 21:51:34 Done.
+ const base::Callback<void(bool, const SkBitmap&)>& callback,
+ bool success,
+ const SkBitmap& bitmap);
#if defined(OS_ANDROID)
virtual void ActivateNearestFindResult(int request_id,
@@ -726,6 +736,8 @@ class CONTENT_EXPORT RenderViewHostImpl
// TODO(nasko): Move to RenderFrameHost, as this is per-frame state.
base::Closure pending_shutdown_on_swap_out_;
+ int copy_requests_;
nasko 2014/03/26 22:48:27 Please add a comment on what this is used for and
mfomitchev 2014/03/27 21:51:34 Done.
+
base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);

Powered by Google App Engine
This is Rietveld 408576698