Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2133823002: Improve hot reload test mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rmacnak review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 70230f4983ad348c0f46fa42e51d107c5b665256..5dfbd393c5bae9e6787bacfbaef2ee0db30ea143 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -303,7 +303,8 @@ abstract class TestSuite {
if (configuration['hot_reload']) {
// Handle reload special cases.
if (expectations.contains(Expectation.COMPILETIME_ERROR)) {
- // Skip reloading tests with expected compilation errors.
+ // Running a test that expects a compilation error with hot reloading
+ // is redundant with a regular run of the test.
return;
}
}
@@ -845,7 +846,11 @@ class StandardTestSuite extends TestSuite {
CreateTest createTestCase = makeTestCaseCreator(optionsFromFile);
if (optionsFromFile['isMultitest']) {
- group.add(doMultitest(filePath, buildDir, suiteDir, createTestCase));
+ group.add(doMultitest(filePath,
+ buildDir,
+ suiteDir,
+ createTestCase,
+ configuration['hot_reload']));
} else {
createTestCase(filePath, filePath, optionsFromFile['hasCompileError'],
optionsFromFile['hasRuntimeError'],
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698