Chromium Code Reviews| Index: tools/testing/dart/multitest.dart |
| diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart |
| index d39bc9ae6a1225824ded5140dd7783f71c77ae30..fc1bdbb489eb737ee213fb2af182977638dc4dad 100644 |
| --- a/tools/testing/dart/multitest.dart |
| +++ b/tools/testing/dart/multitest.dart |
| @@ -221,7 +221,11 @@ Set<String> _findAllRelativeImports(Path topLibrary) { |
| } |
| Future doMultitest( |
| - Path filePath, String outputDir, Path suiteDir, CreateTest doTest) { |
| + Path filePath, |
| + String outputDir, |
| + Path suiteDir, |
| + CreateTest doTest, |
| + bool hotReload) { |
| void writeFile(String filepath, String content) { |
| final File file = new File(filepath); |
| @@ -273,6 +277,12 @@ Future doMultitest( |
| bool isNegativeIfChecked = outcome.contains('dynamic type error'); |
| bool hasCompileErrorIfChecked = |
| outcome.contains('checked mode compile-time error'); |
| + if (hotReload) { |
| + if (hasCompileError || hasCompileErrorIfChecked) { |
| + // Skip multi tests with compilation errors when hot reloading. |
|
rmacnak
2016/07/11 19:18:22
// Running a test that expects a compilation error
Cutch
2016/07/11 19:29:55
Done.
|
| + continue; |
| + } |
| + } |
| doTest(multitestFilename, filePath, hasCompileError, hasRuntimeErrors, |
| isNegativeIfChecked: isNegativeIfChecked, |
| hasCompileErrorIfChecked: hasCompileErrorIfChecked, |