Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2133823002: Improve hot reload test mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 10
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 List<String> sharedOptions, 173 List<String> sharedOptions,
174 List<String> originalArguments, 174 List<String> originalArguments,
175 CommandArtifact artifact) { 175 CommandArtifact artifact) {
176 List<String> args = []; 176 List<String> args = [];
177 if (isChecked) { 177 if (isChecked) {
178 args.add('--enable_asserts'); 178 args.add('--enable_asserts');
179 args.add('--enable_type_checks'); 179 args.add('--enable_type_checks');
180 } 180 }
181 if (hotReload) { 181 if (hotReload) {
182 args.add('--hot-reload-test-mode'); 182 args.add('--hot-reload-test-mode');
183 // Remove the following once known bugs with background compilation
184 // and OSR are fixed.
185 args.add('--no-background-compilation');
186 args.add('--no-osr');
187 } 183 }
188 return args 184 return args
189 ..addAll(vmOptions) 185 ..addAll(vmOptions)
190 ..addAll(sharedOptions) 186 ..addAll(sharedOptions)
191 ..addAll(originalArguments); 187 ..addAll(originalArguments);
192 } 188 }
193 } 189 }
194 190
195 /// Common configuration for dart2js-based tools, such as, dart2js 191 /// Common configuration for dart2js-based tools, such as, dart2js
196 class Dart2xCompilerConfiguration extends CompilerConfiguration { 192 class Dart2xCompilerConfiguration extends CompilerConfiguration {
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 RuntimeConfiguration runtimeConfiguration, 648 RuntimeConfiguration runtimeConfiguration,
653 String buildDir, 649 String buildDir,
654 TestInformation info, 650 TestInformation info,
655 List<String> vmOptions, 651 List<String> vmOptions,
656 List<String> sharedOptions, 652 List<String> sharedOptions,
657 List<String> originalArguments, 653 List<String> originalArguments,
658 CommandArtifact artifact) { 654 CommandArtifact artifact) {
659 return <String>[]; 655 return <String>[];
660 } 656 }
661 } 657 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698