third_party/WebKit/Source/modules/push_messaging/PushSubscription.h - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add MODULES_EXPORT Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

index e21dcbd17cab48ac626c0f0c10b1501dfc8f2965..9a109e83d48ba400e997aea84e9ac73dd7927e2b 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

@@ -17,6 +17,7 @@

namespace blink {

+class PushSubscriptionOptions;

class ServiceWorkerRegistration;

class ScriptPromiseResolver;

class ScriptState;

@@ -30,7 +31,9 @@ public:

virtual ~PushSubscription();

- KURL endpoint() const;

+ KURL endpoint() const { return m_endpoint; }

+ PushSubscriptionOptions* options() const { return m_options.get(); }

DOMArrayBuffer* getKey(const AtomicString& name) const;

ScriptPromise unsubscribe(ScriptState*);

@@ -44,6 +47,8 @@ private:

KURL m_endpoint;

+ Member<PushSubscriptionOptions> m_options;

Member<DOMArrayBuffer> m_p256dh;

Member<DOMArrayBuffer> m_auth;