third_party/WebKit/Source/modules/push_messaging/PushManager.idl - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushManager.idl

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add MODULES_EXPORT Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushManager.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushManager.idl

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushManager.idl b/third_party/WebKit/Source/modules/push_messaging/PushManager.idl

index 7f7f137105d2dc51854e9182bd53c8d11beaab24..67ae036057f8bcf41322bee2f92ea939afdea436 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushManager.idl

+++ b/third_party/WebKit/Source/modules/push_messaging/PushManager.idl

@@ -8,7 +8,7 @@

Exposed=(Window,ServiceWorker),

RuntimeEnabled=PushMessaging,

] interface PushManager {

- [CallWith=ScriptState, RaisesException] Promise<PushSubscription> subscribe(optional PushSubscriptionOptions options);

+ [CallWith=ScriptState, RaisesException] Promise<PushSubscription> subscribe(optional PushSubscriptionOptionsInit options);

[CallWith=ScriptState] Promise<PushSubscription?> getSubscription();

- [CallWith=ScriptState, RaisesException] Promise permissionState(optional PushSubscriptionOptions options);

+ [CallWith=ScriptState, RaisesException] Promise permissionState(optional PushSubscriptionOptionsInit options);

};