Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushManager.h

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add MODULES_EXPORT Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/push_messaging/PushManager.h
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushManager.h b/third_party/WebKit/Source/modules/push_messaging/PushManager.h
index 358501296dc756d1bc130c3839fff3e46f7c6c6b..2babae078c36e54ae94c813fe96856d2b1654044 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushManager.h
+++ b/third_party/WebKit/Source/modules/push_messaging/PushManager.h
@@ -12,11 +12,10 @@
namespace blink {
class ExceptionState;
-class PushSubscriptionOptions;
+class PushSubscriptionOptionsInit;
class ScriptPromise;
class ScriptState;
class ServiceWorkerRegistration;
-struct WebPushSubscriptionOptions;
class MODULES_EXPORT PushManager final : public GarbageCollected<PushManager>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
@@ -26,17 +25,12 @@ public:
return new PushManager(registration);
}
- ScriptPromise subscribe(ScriptState*, const PushSubscriptionOptions&,
- ExceptionState&);
+ ScriptPromise subscribe(ScriptState*, const PushSubscriptionOptionsInit&, ExceptionState&);
ScriptPromise getSubscription(ScriptState*);
- ScriptPromise permissionState(ScriptState*, const PushSubscriptionOptions&,
- ExceptionState&);
+ ScriptPromise permissionState(ScriptState*, const PushSubscriptionOptionsInit&, ExceptionState&);
DECLARE_TRACE();
- static WebPushSubscriptionOptions toWebPushSubscriptionOptions(
- const PushSubscriptionOptions&, ExceptionState&);
-
private:
explicit PushManager(ServiceWorkerRegistration*);
« no previous file with comments | « third_party/WebKit/Source/modules/modules.gypi ('k') | third_party/WebKit/Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698