third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl ('K') | « third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl ('k') | third_party/WebKit/public/platform/modules/push_messaging/WebPushSubscription.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl

similarity index 74%

copy from third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl

copy to third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl

index e4ee9b8108955c09827a3cbe1202e27a89e5a925..0e46a8833cff91b9fdad482d8d733d59265f8ffe 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl

@@ -2,9 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptions

+// https://w3c.github.io/push-api/#idl-def-PushSubscriptionOptionsInit

-dictionary PushSubscriptionOptions {

+dictionary PushSubscriptionOptionsInit {

boolean userVisibleOnly = false;

- BufferSource applicationServerKey;

+ BufferSource? applicationServerKey = null;

};