Form control focus by click on a label should be handled as same as focus

Form control focus by click on a label should be handled as same as focus
by mouse down on the control.

This is a follow-up of Blink r153039.
Some form controls don't show focus rings by mouse press. Focus by click
on a label should have same bahavior.

BUG=265793
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155315

[tkent, 2013-07-31 03:19:31]

Keishi, would you review this please?

[keishi, 2013-08-01 05:39:36]

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
File LayoutTests/fast/forms/button/button-focus-by-label-click.html (right):

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
LayoutTests/fast/forms/button/button-focus-by-label-click.html:7:
clickElement(document.querySelector('label'));
clickElement clicks the center of the element. The button element is probably
wider than the " Label" text node so wouldn't the click happen on the button
element? The test should probably be clear whether it is clicking on "Button" or
" Label".

[tkent, 2013-08-01 05:48:49]

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
File LayoutTests/fast/forms/button/button-focus-by-label-click.html (right):

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
LayoutTests/fast/forms/button/button-focus-by-label-click.html:7:
clickElement(document.querySelector('label'));
On 2013/08/01 05:39:36, keishi1 wrote:
> clickElement clicks the center of the element. The button element is probably
> wider than the " Label" text node so wouldn't the click happen on the button
> element? The test should probably be clear whether it is clicking on "Button"
or
> " Label".

That's the reason why the label element has display:block.  Do you think <button
id=b>...</button><label for=b>...</label> is better for readability?

[keishi, 2013-08-01 06:00:20]

lgtm

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
File LayoutTests/fast/forms/button/button-focus-by-label-click.html (right):

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
LayoutTests/fast/forms/button/button-focus-by-label-click.html:7:
clickElement(document.querySelector('label'));
On 2013/08/01 05:48:49, tkent wrote:
> On 2013/08/01 05:39:36, keishi1 wrote:
> > clickElement clicks the center of the element. The button element is
probably
> > wider than the " Label" text node so wouldn't the click happen on the button
> > element? The test should probably be clear whether it is clicking on
"Button"
> or
> > " Label".
> 
> That's the reason why the label element has display:block.  Do you think
<button
> id=b>...</button><label for=b>...</label> is better for readability?
> 
I see. Yes I would prefer that if possible.

[tkent, 2013-08-01 06:17:27]

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
File LayoutTests/fast/forms/button/button-focus-by-label-click.html (right):

https://codereview.chromium.org/21321002/diff/5001/LayoutTests/fast/forms/but...
LayoutTests/fast/forms/button/button-focus-by-label-click.html:7:
clickElement(document.querySelector('label'));
On 2013/08/01 06:00:20, keishi1 wrote:
> On 2013/08/01 05:48:49, tkent wrote:
> > On 2013/08/01 05:39:36, keishi1 wrote:
> > > clickElement clicks the center of the element. The button element is
> probably
> > > wider than the " Label" text node so wouldn't the click happen on the
button
> > > element? The test should probably be clear whether it is clicking on
> "Button"
> > or
> > > " Label".
> > 
> > That's the reason why the label element has display:block.  Do you think
> <button
> > id=b>...</button><label for=b>...</label> is better for readability?
> > 
> I see. Yes I would prefer that if possible.

ok, I updated the test.

[commit-bot: I haz the power, 2013-08-01 06:17:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/21321002/13001

[commit-bot: I haz the power, 2013-08-01 08:25:42]

Change committed as 155315