Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2009)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_android.h

Issue 2132023002: Store the notification id as a string for Android notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event_api
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_android.h
diff --git a/chrome/browser/notifications/notification_platform_bridge_android.h b/chrome/browser/notifications/notification_platform_bridge_android.h
index 23830efce104dea4bfe5ea92a359cd1cf8e8fc95..8464065bd05bd90f55af664c641615fcd3b45632 100644
--- a/chrome/browser/notifications/notification_platform_bridge_android.h
+++ b/chrome/browser/notifications/notification_platform_bridge_android.h
@@ -41,7 +41,7 @@ class NotificationPlatformBridgeAndroid : public NotificationPlatformBridge {
void OnNotificationClicked(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& java_object,
- jlong persistent_notification_id,
+ const base::android::JavaParamRef<jstring>& java_notification_id,
const base::android::JavaParamRef<jstring>& java_origin,
const base::android::JavaParamRef<jstring>& java_profile_id,
jboolean incognito,
@@ -53,7 +53,7 @@ class NotificationPlatformBridgeAndroid : public NotificationPlatformBridge {
void OnNotificationClosed(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& java_object,
- jlong persistent_notification_id,
+ const base::android::JavaParamRef<jstring>& java_notification_id,
const base::android::JavaParamRef<jstring>& java_origin,
const base::android::JavaParamRef<jstring>& java_profile_id,
jboolean incognito,
@@ -94,10 +94,10 @@ class NotificationPlatformBridgeAndroid : public NotificationPlatformBridge {
std::string webapk_package;
};
- // Mapping of a persistent notification id to renegerated notification info.
+ // Mapping of notification id to renegerated notification info.
// TODO(peter): Remove this map once notification delegate ids for Web
// notifications are created by the content/ layer.
- std::map<int64_t, RegeneratedNotificationInfo>
+ std::map<std::string, RegeneratedNotificationInfo>
regenerated_notification_infos_;
base::android::ScopedJavaGlobalRef<jobject> java_object_;

Powered by Google App Engine
This is Rietveld 408576698