Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 213193002: Make MemoryCache::contains() take a const Resource pointer. (Closed)

Created:
6 years, 9 months ago by Philippe
Modified:
6 years, 9 months ago
Reviewers:
clamy, Nate Chapin, pliard
CC:
blink-reviews, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make MemoryCache::contains() take a const Resource pointer. This is needed by const-method clients such as "Resource::canDelete() const". BUG=290193 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/fetch/MemoryCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Philippe
Hey Nate, I think Camille will need this very small change in order to land ...
6 years, 9 months ago (2014-03-26 16:40:21 UTC) #1
Nate Chapin
On 2014/03/26 16:40:21, Philippe wrote: > Hey Nate, I think Camille will need this very ...
6 years, 9 months ago (2014-03-26 17:11:30 UTC) #2
Philippe
On 2014/03/26 17:11:30, Nate Chapin wrote: > On 2014/03/26 16:40:21, Philippe wrote: > > Hey ...
6 years, 9 months ago (2014-03-26 17:14:21 UTC) #3
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 9 months ago (2014-03-26 17:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/213193002/1
6 years, 9 months ago (2014-03-26 17:14:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:22:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 18:22:32 UTC) #7
pliard
The CQ bit was checked by pliard@google.com
6 years, 9 months ago (2014-03-27 06:51:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/213193002/1
6 years, 9 months ago (2014-03-27 06:51:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 07:58:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 07:58:10 UTC) #11
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 9 months ago (2014-03-27 08:45:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/213193002/1
6 years, 9 months ago (2014-03-27 08:45:49 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 09:49:55 UTC) #14
Message was sent while issue was closed.
Change committed as 170154

Powered by Google App Engine
This is Rietveld 408576698