Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 21297005: <webview>: Refactor Permission API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_permissions
Patch Set: Fixed some bugs Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index df98e4fd7ed7dd0fb66a024bcc23660007a815da..961cc4dcb75a79d8a536c48ecacfb1b19cfad6f3 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -5,9 +5,12 @@
#ifndef CONTENT_PUBLIC_BROWSER_BROWSER_PLUGIN_GUEST_DELEGATE_H_
#define CONTENT_PUBLIC_BROWSER_BROWSER_PLUGIN_GUEST_DELEGATE_H_
+#include "base/callback.h"
#include "base/process/kill.h"
#include "base/strings/string16.h"
+#include "base/values.h"
#include "content/common/content_export.h"
+#include "content/public/common/browser_plugin/browser_plugin_message_enums.h"
namespace content {
@@ -17,6 +20,10 @@ struct NativeWebKeyboardEvent;
// WebContents and to provide necessary functionality.
class CONTENT_EXPORT BrowserPluginGuestDelegate {
public:
+ typedef base::Callback<void(bool /* allow */,
lazyboy 2013/08/05 09:26:58 nit: indentation is off
Fady Samuel 2013/08/06 07:14:40 I'm not actually sure what the correct indentation
+ const std::string& /* user_input */)>
+ PermissionResponseCallback;
+
virtual ~BrowserPluginGuestDelegate() {}
// Add a message to the console.
@@ -41,6 +48,11 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// Notification that the guest is hung.
virtual void RendererUnresponsive() {}
+
+ virtual bool RequestPermission(
lazyboy 2013/08/05 09:26:58 Add comment about the method.
Fady Samuel 2013/08/06 07:14:40 Done.
+ BrowserPluginPermissionType permission_type,
+ const base::DictionaryValue& request_info,
+ const PermissionResponseCallback& callback);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698