Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 212873006: input_device_settings: Changed script invocations to use new scripts (Closed)

Created:
6 years, 9 months ago by denniskempin (chromium)
Modified:
6 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

input_device_settings: Changed script invocations to use new scripts tpcontrol and mousecontrol have been merged into a new script for controlling input devices. This CL updates input_device_settings to use this new script. BUG=chromium:285663 TEST=Has to be tested with chromium-side CLs containing the new script. Then make sure changing mouse and touchpad preferences is working well and that your preferences are correctly applied on bootup. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260226

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixed Nits #

Patch Set 3 : Re-did nit fixes. Previous patch set was messed up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M chrome/browser/chromeos/system/input_device_settings.cc View 1 2 7 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
denniskempin (chromium)
6 years, 9 months ago (2014-03-26 22:32:16 UTC) #1
achuithb
https://chromiumcodereview.appspot.com/212873006/diff/1/chrome/browser/chromeos/system/input_device_settings.cc File chrome/browser/chromeos/system/input_device_settings.cc (right): https://chromiumcodereview.appspot.com/212873006/diff/1/chrome/browser/chromeos/system/input_device_settings.cc#newcode36 chrome/browser/chromeos/system/input_device_settings.cc:36: const char kTouchpad[] = "touchpad"; kDeviceTypeTouchpad https://chromiumcodereview.appspot.com/212873006/diff/1/chrome/browser/chromeos/system/input_device_settings.cc#newcode37 chrome/browser/chromeos/system/input_device_settings.cc:37: const ...
6 years, 9 months ago (2014-03-27 00:18:49 UTC) #2
denniskempin (chromium)
fixed all nits. Please re-review. I'll be doing another test run now that the chromiumos-side ...
6 years, 9 months ago (2014-03-27 17:36:58 UTC) #3
achuithb
lgtm, thanks.
6 years, 9 months ago (2014-03-27 17:39:02 UTC) #4
denniskempin (chromium)
The CQ bit was checked by denniskempin@chromium.org
6 years, 9 months ago (2014-03-28 16:21:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/denniskempin@chromium.org/212873006/40001
6 years, 9 months ago (2014-03-28 16:26:59 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 19:09:01 UTC) #7
Message was sent while issue was closed.
Change committed as 260226

Powered by Google App Engine
This is Rietveld 408576698