chrome/test/ppapi/ppapi_filechooser_browsertest.cc - Issue 2127373006: Use base::StartWith() in more places when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/ppapi/ppapi_filechooser_browsertest.cc

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build, fix error Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_http_client.cc ('k') | chrome/utility/media_galleries/picasa_albums_indexer.cc » ('j') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/ppapi/ppapi_filechooser_browsertest.cc

diff --git a/chrome/test/ppapi/ppapi_filechooser_browsertest.cc b/chrome/test/ppapi/ppapi_filechooser_browsertest.cc

index 90816e996ad020f19ba9406d856d5c190fee6f25..b57a91ea7d794d83435ae24a1abc8e3b7f8f162a 100644

--- a/chrome/test/ppapi/ppapi_filechooser_browsertest.cc

+++ b/chrome/test/ppapi/ppapi_filechooser_browsertest.cc

@@ -8,6 +8,7 @@

#include "base/command_line.h"

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

+#include "base/strings/string_util.h"

#include "base/threading/thread_task_runner_handle.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/test/ppapi/ppapi_test.h"

@@ -147,7 +148,8 @@ class FakeDatabaseManager

bool MatchDownloadWhitelistUrl(const GURL& url) override {

// This matches the behavior in RunTestViaHTTP().

return url.SchemeIsHTTPOrHTTPS() && url.has_path() &&

- url.path().find("/test_case.html") == 0;

+ base::StartsWith(url.path(), "/test_case.html",

+ base::CompareCase::SENSITIVE);

}

protected: