chrome/test/chromedriver/chrome/chrome_desktop_impl.cc - Issue 2127373006: Use base::StartWith() in more places when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build, fix error Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/browser_info.cc ('k') | chrome/test/chromedriver/chrome/devtools_http_client.cc » ('j') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

index a9685328013b4b62b0305f5e1276360797d27616..65784da87080d11c3166825cf5505de5e14aaf48 100644

--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

@@ -11,6 +11,7 @@

#include "base/logging.h"

#include "base/posix/eintr_wrapper.h"

#include "base/process/kill.h"

+#include "base/strings/string_util.h"

#include "base/sys_info.h"

#include "base/threading/platform_thread.h"

#include "base/time/time.h"

@@ -122,7 +123,7 @@ Status ChromeDesktopImpl::WaitForPageToLoad(

for (size_t i = 0; i < views_info.GetSize(); ++i) {

const WebViewInfo& view_info = views_info.Get(i);

- if (view_info.url.find(url) == 0) {

+ if (base::StartsWith(view_info.url, url, base::CompareCase::SENSITIVE)) {

id = view_info.id;

type = view_info.type;

break;