Linux doubles line gap when no VDMX table present

On linux when no VDMX table is present the leading is applied twice causing the line gap to be doubled.

When isVDMXValid is false, the following effectively happens:

descent = metrics.fDescent + metrics.fLeading;
lineGap = SkScalarToFloat(metrics.fLeading);
m_fontMetrics.setLineGap(lineGap);
m_fontMetrics.setLineSpacing(ascent + descent + lineGap);

Note that since descent already incorporates the fLeading, the fLeading will be applied twice in the total height. When isVDMXValid is true, the descent does not incorporate the fLeading.

BUG=265268
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156936

[bungeman-chromium, 2013-08-29 20:36:16]

lgtm

[pdr., 2013-08-29 20:52:05]

On 2013/08/29 20:36:16, bungeman2 wrote:
> lgtm

LGTM

[commit-bot: I haz the power, 2013-08-29 20:54:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/21259002/37001

[commit-bot: I haz the power, 2013-08-29 20:58:10]

Change committed as 156936