Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: Source/modules/device_orientation/NewDeviceOrientationController.cpp

Issue 21256002: Fire null Device Motion events only once. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/device_orientation/NewDeviceOrientationController.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2010 Apple Inc. All rights reserved. 2 * Copyright 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 3 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above copyright 10 * * Redistributions in binary form must reproduce the above copyright
(...skipping 10 matching lines...) Expand all
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "modules/device_orientation/NewDeviceOrientationController.h" 28 #include "modules/device_orientation/NewDeviceOrientationController.h"
29 29
30 #include "core/dom/Document.h" 30 #include "core/dom/Document.h"
31 #include "modules/device_orientation/DeviceOrientationData.h"
31 #include "modules/device_orientation/DeviceOrientationDispatcher.h" 32 #include "modules/device_orientation/DeviceOrientationDispatcher.h"
32 #include "modules/device_orientation/DeviceOrientationEvent.h" 33 #include "modules/device_orientation/DeviceOrientationEvent.h"
33 34
34 namespace WebCore { 35 namespace WebCore {
35 36
36 NewDeviceOrientationController::NewDeviceOrientationController(Document* documen t) 37 NewDeviceOrientationController::NewDeviceOrientationController(Document* documen t)
37 : DeviceSensorEventController(document) 38 : DeviceSensorEventController(document)
38 { 39 {
39 } 40 }
40 41
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 void NewDeviceOrientationController::registerWithDispatcher() 77 void NewDeviceOrientationController::registerWithDispatcher()
77 { 78 {
78 DeviceOrientationDispatcher::instance().addDeviceOrientationController(this) ; 79 DeviceOrientationDispatcher::instance().addDeviceOrientationController(this) ;
79 } 80 }
80 81
81 void NewDeviceOrientationController::unregisterWithDispatcher() 82 void NewDeviceOrientationController::unregisterWithDispatcher()
82 { 83 {
83 DeviceOrientationDispatcher::instance().removeDeviceOrientationController(th is); 84 DeviceOrientationDispatcher::instance().removeDeviceOrientationController(th is);
84 } 85 }
85 86
87 bool NewDeviceOrientationController::isNullEvent(Event* event)
88 {
89 ASSERT(event->type() == eventNames().devicemotionEvent);
90 DeviceOrientationEvent* orientationEvent = static_cast<DeviceOrientationEven t*>(event);
91 return !orientationEvent->orientation()->canProvideEventData();
92 }
93
86 } // namespace WebCore 94 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/device_orientation/NewDeviceOrientationController.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698