Fire null Device Motion events only once.

Source/modules/device_orientation/NewDeviceOrientationController.cpp

 /*
  * Copyright 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/device_orientation/NewDeviceOrientationController.h"
 
 #include "core/dom/Document.h"
+#include "modules/device_orientation/DeviceOrientationData.h"
 #include "modules/device_orientation/DeviceOrientationDispatcher.h"
 #include "modules/device_orientation/DeviceOrientationEvent.h"
 
+

[abarth-chromium, 2013/07/31 00:56:19]

This blank line looks spurious.

[timvolodine, 2013/07/31 13:59:00]

Done.

 namespace WebCore {
 
 NewDeviceOrientationController::NewDeviceOrientationController(Document* document)
     : DeviceSensorEventController(document)
 {
 }
 
 NewDeviceOrientationController::~NewDeviceOrientationController()
 {
 }
@@ skipping 32 matching lines @@
 void NewDeviceOrientationController::registerWithDispatcher()
 {
     DeviceOrientationDispatcher::instance().addDeviceOrientationController(this);
 }
 
 void NewDeviceOrientationController::unregisterWithDispatcher()
 {
     DeviceOrientationDispatcher::instance().removeDeviceOrientationController(this);
 }
 
+bool NewDeviceOrientationController::isNullEvent(Event* event)
+{
+    DeviceOrientationEvent* orientationEvent = static_cast<DeviceOrientationEvent*>(event);

[abarth-chromium, 2013/07/31 00:56:19]

Same comment about this blind static_cast.

[timvolodine, 2013/07/31 13:59:00]

added assert (analogous to the motion case).

+    DeviceOrientationData* data = orientationEvent->orientation();
+    return !data->canProvideAlpha() && !data->canProvideBeta() && !data->canProvideGamma();

[abarth-chromium, 2013/07/31 00:56:19]

Do we have any mechanism to keep this check up to date in the case that
DeviceOrientationEvent adds more fields over time?

[timvolodine, 2013/07/31 13:59:00]

hmm, good point -- I've moved some of the code to canProvideEventData() in
DeviceMotionData and DeviceOrientationData, it looks a better place to test
'null-ness' there.

+}
+
 } // namespace WebCore