Added UMA metrics for the system update UI in the status area.

Added UMA metrics for the system update UI in the status area.

Record user action when:
- User clicks the update menu item in the system menu

BUG=620508
TEST=manual

Committed: https://crrev.com/952e67d3df2535e967cd937e002998d5ccbbb12b
Cr-Commit-Position: refs/heads/master@{#404505}

[bruthig, 2016-07-07 20:51:56]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-07-07 20:51:57]

Terry, can you please take a first look?

[tdanderson, 2016-07-07 21:36:43]

lgtm with nits

https://chromiumcodereview.appspot.com/2125403002/diff/1/ash/metrics/user_met...
File ash/metrics/user_metrics_recorder.cc (right):

https://chromiumcodereview.appspot.com/2125403002/diff/1/ash/metrics/user_met...
ash/metrics/user_metrics_recorder.cc:508:
base::UserMetricsAction("StatusArea_Update_Default_Clicked"));
nit: consider dropping "_Clicked" from the action name to be consistent with
other _CLICKED cases (see line 510 for example)

Also consider dropping "default" from the name since it's not needed for
disambiguation and I don't see that naming convention used elsewhere in this
file.

https://chromiumcodereview.appspot.com/2125403002/diff/1/tools/metrics/action...
File tools/metrics/actions/actions.xml (right):

https://chromiumcodereview.appspot.com/2125403002/diff/1/tools/metrics/action...
tools/metrics/actions/actions.xml:13922: Counts the number of times the user
clicks the update row in the system
nit: "clicks" -> "selects" or "clicks/taps"

[bruthig, 2016-07-08 17:49:43]

bruthig@chromium.org changed reviewers:
+ jamescook@chromium.org, rkaplow@chromium.org

[bruthig, 2016-07-08 17:49:44]

jamescook@, can you review changes in:
- ash/common/system/update/tray_update.cc

rkaplow@, can you review changes in:
- tools/metrics/actions/actions.xml
- ash/metrics/user_metrics_recorder.cc

https://chromiumcodereview.appspot.com/2125403002/diff/1/ash/metrics/user_met...
File ash/metrics/user_metrics_recorder.cc (right):

https://chromiumcodereview.appspot.com/2125403002/diff/1/ash/metrics/user_met...
ash/metrics/user_metrics_recorder.cc:508:
base::UserMetricsAction("StatusArea_Update_Default_Clicked"));
On 2016/07/07 21:36:43, tdanderson wrote:
> nit: consider dropping "_Clicked" from the action name to be consistent with
> other _CLICKED cases (see line 510 for example)
> 
> Also consider dropping "default" from the name since it's not needed for
> disambiguation and I don't see that naming convention used elsewhere in this
> file.

Acknowledged.

https://chromiumcodereview.appspot.com/2125403002/diff/1/tools/metrics/action...
File tools/metrics/actions/actions.xml (right):

https://chromiumcodereview.appspot.com/2125403002/diff/1/tools/metrics/action...
tools/metrics/actions/actions.xml:13922: Counts the number of times the user
clicks the update row in the system
On 2016/07/07 21:36:43, tdanderson wrote:
> nit: "clicks" -> "selects" or "clicks/taps"

Done.

[James Cook, 2016-07-08 18:09:00]

LGTM with another naming suggestion

(I think TrayUpdate is poorly named too, but that's a problem for another day.)

https://chromiumcodereview.appspot.com/2125403002/diff/40001/ash/common/metri...
File ash/common/metrics/user_metrics_action.h (right):

https://chromiumcodereview.appspot.com/2125403002/diff/40001/ash/common/metri...
ash/common/metrics/user_metrics_action.h:94:
UMA_STATUS_AREA_UPDATE_DEFAULT_SELECTED,
nit: I would call this "OS_UPDATE" or "UPDATER" or something else. Otherwise it
sounds like a status-area-update.

[rkaplow, 2016-07-08 20:04:57]

lgtm

[bruthig, 2016-07-08 20:24:00]

https://codereview.chromium.org/2125403002/diff/40001/ash/common/metrics/user...
File ash/common/metrics/user_metrics_action.h (right):

https://codereview.chromium.org/2125403002/diff/40001/ash/common/metrics/user...
ash/common/metrics/user_metrics_action.h:94:
UMA_STATUS_AREA_UPDATE_DEFAULT_SELECTED,
On 2016/07/08 18:09:00, James Cook wrote:
> nit: I would call this "OS_UPDATE" or "UPDATER" or something else. Otherwise
it
> sounds like a status-area-update.

Done.

[bruthig, 2016-07-08 20:24:11]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-07-08 20:24:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, jamescook@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2125403002/#ps60001
(title: "Changed metric name from UPDATE to OS_UPDATE.")

[commit-bot: I haz the power, 2016-07-08 20:24:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 20:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:26:40]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, no build URL)

[bruthig, 2016-07-08 21:15:45]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-07-08 21:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, jamescook@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2125403002/#ps80001
(title: "Merge branch 'master' into uma_update")

[commit-bot: I haz the power, 2016-07-08 21:16:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 22:06:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-08 22:07:02]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 22:09:21]

Description was changed from

==========
Added UMA metrics for the system update UI in the status area.

Record user action when:
- User clicks the update menu item in the system menu

BUG=620508
TEST=manual
==========

to

==========
Added UMA metrics for the system update UI in the status area.

Record user action when:
- User clicks the update menu item in the system menu

BUG=620508
TEST=manual

Committed: https://crrev.com/952e67d3df2535e967cd937e002998d5ccbbb12b
Cr-Commit-Position: refs/heads/master@{#404505}
==========

[commit-bot: I haz the power, 2016-07-08 22:09:23]

Patchset 5 (id:??) landed as
https://crrev.com/952e67d3df2535e967cd937e002998d5ccbbb12b
Cr-Commit-Position: refs/heads/master@{#404505}