Issue 21244002: Remove sourceOnDrive and targetOnDrive from FileCopyManager.Task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21244002: Remove sourceOnDrive and targetOnDrive from FileCopyManager.Task. (Closed)

Created:
7 years, 4 months ago by hidehiko

Modified:
7 years, 4 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org, hirono

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove sourceOnDrive and targetOnDrive from FileCopyManager.Task. These variables are used only in serviceNextCopyTaskEntry_, and are easily calculated from the path. This simplifies the codes. BUG=246976 TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214706

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -44 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_copy_manager.js	View	11 chunks	+17 lines, -36 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager_commands.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_transfer_controller.js	View	2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/21244002/1

7 years, 4 months ago (2013-07-31 04:03:24 UTC) #3

Message was sent while issue was closed.

Change committed as 214706

Expand Messages | Collapse Messages