Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index 2981c676900ba05bc351b550f60950b1ea2eb1a6..82dc39cfdfbec46374c9e89742407df16577cc3e 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -53,6 +53,7 @@
#include "content/public/browser/web_contents.h"
#if BUILDFLAG(ANDROID_JAVA_UI)
+#include "chrome/browser/android/banners/app_banner_manager_android.h"
#include "chrome/browser/android/data_usage/data_use_tab_helper.h"
#include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
#include "chrome/browser/android/offline_pages/recent_tab_helper.h"
@@ -182,6 +183,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
// --- Platform-specific tab helpers ---
#if BUILDFLAG(ANDROID_JAVA_UI)
+ banners::AppBannerManagerAndroid::CreateForWebContents(web_contents);
ContextMenuHelper::CreateForWebContents(web_contents);
DataUseTabHelper::CreateForWebContents(web_contents);
@@ -212,9 +214,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
ThumbnailTabHelper::CreateForWebContents(web_contents);
web_modal::WebContentsModalDialogManager::CreateForWebContents(web_contents);
- if (banners::AppBannerManagerDesktop::IsEnabled()) {
+ if (banners::AppBannerManagerDesktop::IsEnabled())
banners::AppBannerManagerDesktop::CreateForWebContents(web_contents);
- }
#endif
// --- Feature tab helpers behind flags ---
« chrome/browser/banners/app_banner_manager.h ('K') | « chrome/browser/banners/app_banner_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698