Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5236)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 5fd2ccae065c74edc0bb147159c3f8dfc5d89848..16bd77d619dc808acf37e071a981bf2de241d59d 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -172,7 +172,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@Override
protected void setUp() throws Exception {
mPackageManager = new TestPackageManager();
- AppBannerManager.setIsEnabledForTesting(true);
+ AppBannerManager.setIsSupported(true);
AppBannerInfoBarDelegateAndroid.setPackageManagerForTesting(mPackageManager);
ShortcutHelper.setDelegateForTests(new ShortcutHelper.Delegate() {
@Override
@@ -223,8 +223,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
- AppBannerManager manager =
- getActivity().getActivityTab().getAppBannerManagerForTesting();
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
return mDetailsDelegate.mNumRetrieved == numExpected
&& !manager.isFetcherActiveForTesting();
}
@@ -313,8 +312,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
- AppBannerManager manager =
- getActivity().getActivityTab().getAppBannerManagerForTesting();
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
return !manager.isFetcherActiveForTesting();
}
});
@@ -326,8 +324,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
- AppBannerManager manager =
- getActivity().getActivityTab().getAppBannerManagerForTesting();
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
return !manager.isFetcherActiveForTesting();
}
});
@@ -486,8 +483,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
- AppBannerManager manager =
- getActivity().getActivityTab().getAppBannerManagerForTesting();
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
return !manager.isFetcherActiveForTesting();
}
});
@@ -504,8 +500,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
CriteriaHelper.pollUiThread(new Criteria() {
@Override
public boolean isSatisfied() {
- AppBannerManager manager =
- getActivity().getActivityTab().getAppBannerManagerForTesting();
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
return !manager.isFetcherActiveForTesting();
}
});

Powered by Google App Engine
This is Rietveld 408576698