chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java - Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java » ('j') | chrome/browser/banners/app_banner_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

index ac731f266fff484a13e769312a7b4ff636d7ed78..2585012738dfdd9a738e52a007eff55d10dac92e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

@@ -4,7 +4,6 @@

package org.chromium.chrome.browser.tab;

-import org.chromium.chrome.browser.banners.AppBannerManager;

import org.chromium.chrome.browser.contextmenu.ChromeContextMenuPopulator;

import org.chromium.chrome.browser.contextmenu.ContextMenuPopulator;

import org.chromium.components.navigation_interception.InterceptNavigationDelegate;

@@ -43,12 +42,12 @@ public class TabDelegateFactory {

}

/**

- * Creates the {@link AppBannerManager} the tab will be initialized with.

+ * Return true if app banners are to be permitted in this tab.

* @param tab The associated {@link Tab}.

- * @return {@link AppBannerManager} to be used for the given tab. May be null.

+ * @return true if app banners are permitted, and false otherwise.

- public AppBannerManager createAppBannerManager(Tab tab) {

- return new AppBannerManager(tab, tab.getApplicationContext());

+ public boolean canShowAppBanners(Tab tab) {

+ return true;

}

/**