chrome/browser/banners/app_banner_manager.h - Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « chrome/browser/android/tab_web_contents_delegate_android.cc ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_manager.h

diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h

index b42eb32ba83807f4fc785eeec4af3cf513a5615e..20969abb1a74ed8bbec2558d8442e49f45c71a7d 100644

--- a/chrome/browser/banners/app_banner_manager.h

+++ b/chrome/browser/banners/app_banner_manager.h

@@ -40,7 +40,7 @@ class AppBannerManager : public content::WebContentsObserver,

// Requests an app banner. Set |is_debug_mode| when it is triggered by the

// developer's action in DevTools.

- void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);

+ virtual void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);

~AppBannerManager() override;