Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.cc

Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_web_contents_delegate_android.cc
diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc
index 81f87c8c36ef1e3c09f55b6ef5126a339dc2c808..41e99e78e3cbed3b5bd0b5040aab0753780ce26c 100644
--- a/chrome/browser/android/tab_web_contents_delegate_android.cc
+++ b/chrome/browser/android/tab_web_contents_delegate_android.cc
@@ -10,6 +10,7 @@
#include "base/android/jni_string.h"
#include "base/command_line.h"
#include "base/memory/ptr_util.h"
+#include "chrome/browser/android/banners/app_banner_manager_android.h"
#include "chrome/browser/android/feature_utilities.h"
#include "chrome/browser/android/hung_renderer_infobar_delegate.h"
#include "chrome/browser/android/media/media_throttle_infobar_delegate.h"
@@ -417,11 +418,9 @@ void TabWebContentsDelegateAndroid::AddNewContents(
void TabWebContentsDelegateAndroid::RequestAppBannerFromDevTools(
content::WebContents* web_contents) {
- JNIEnv* env = base::android::AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
- if (obj.is_null())
- return;
- Java_TabWebContentsDelegateAndroid_requestAppBanner(env, obj.obj());
+ banners::AppBannerManagerAndroid* manager =
+ banners::AppBannerManagerAndroid::FromWebContents(web_contents);
+ manager->RequestAppBanner(web_contents->GetLastCommittedURL(), true);
}
} // namespace android

Powered by Google App Engine
This is Rietveld 408576698