ScreenCapture for Android phase1, part II

chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tab;
 
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.ActivityManager;
 import android.content.Context;
 import android.content.Intent;
 import android.graphics.Rect;
 import android.graphics.RectF;
 import android.media.AudioManager;
 import android.os.Build;
 import android.os.Handler;
 import android.util.Pair;
+import android.util.SparseArray;
 import android.view.KeyEvent;
 import android.view.View;
 
 import org.chromium.base.Log;
 import org.chromium.base.ObserverList.RewindableIterator;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.blink_public.platform.WebDisplayMode;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeApplication;
 import org.chromium.chrome.browser.RepostFormWarningDialog;
@@ skipping 39 matching lines @@
 
     protected final Tab mTab;
 
     private FindResultListener mFindResultListener;
 
     private FindMatchRectsListener mFindMatchRectsListener = null;
 
     private int mDisplayMode = WebDisplayMode.Browser;
 
     protected Handler mHandler;
+    // Static array for NotifyStopped() method under a static context for screen capture.
+    private static SparseArray<WebContents> sWebContentsMap = new SparseArray<WebContents>();

[gone, 2016/08/10 19:04:02]

1) private static final
2) Use javadoc syntax: 
   /** Static array for blah blah. */

[braveyao, 2016/08/12 23:37:44]

Done. Removed.

+
     private final Runnable mCloseContentsRunnable = new Runnable() {
         @Override
         public void run() {
             boolean isSelected = mTab.getTabModelSelector().getCurrentTab() == mTab;
             mTab.getTabModelSelector().closeTab(mTab);
 
             // If the parent Tab belongs to another Activity, fire the Intent to bring it back.
             if (isSelected && mTab.getParentIntent() != null
                     && mTab.getActivity().getIntent() != mTab.getParentIntent()) {
                 boolean mayLaunch = FeatureUtilities.isDocumentMode(mTab.getApplicationContext())
@@ skipping 132 matching lines @@
 
         RewindableIterator<TabObserver> observers = mTab.getTabObservers();
         while (observers.hasNext()) {
             observers.next().onToggleFullscreenMode(mTab, enableFullscreen);
         }
     }
 
     @Override
     public void navigationStateChanged(int flags) {
         if ((flags & InvalidateTypes.TAB) != 0) {
+            int mediaType = MediaCaptureNotificationService.getMediaType(
+                    isCapturingAudio(), isCapturingVideo(), isCapturingScreen());
+            // Update webcontents map for notifying stop action to native for screen capture.
+            if (isCapturingScreen()) {
+                sWebContentsMap.put(mTab.getId(), mTab.getWebContents());

[gone, 2016/08/10 19:04:02]

1) Tabs can swap their WebContents, but you don't seem to be accounting for
this.

2) You use mTab.getWebContents() here and in isCapturingScreen(), but you use
the map
   in notifyStopped.  Why?

[braveyao, 2016/08/12 23:37:44]

Done.
Use the newly added TabWindowManager#getTabById() API now.

+            } else {
+                sWebContentsMap.delete(mTab.getId());
+            }
+
             MediaCaptureNotificationService.updateMediaNotificationForTab(
-                    mTab.getApplicationContext(), mTab.getId(), isCapturingAudio(),
-                    isCapturingVideo(), mTab.getUrl());
+                    mTab.getApplicationContext(), mTab.getId(), mediaType, mTab.getUrl());
         }
         if ((flags & InvalidateTypes.TITLE) != 0) {
             // Update cached title then notify observers.
             mTab.updateTitle();
         }
         if ((flags & InvalidateTypes.URL) != 0) {
             RewindableIterator<TabObserver> observers = mTab.getTabObservers();
             while (observers.hasNext()) {
                 observers.next().onUrlUpdated(mTab);
             }
@@ skipping 226 matching lines @@
         return !mTab.isClosing() && nativeIsCapturingAudio(mTab.getWebContents());
     }
 
     /**
      * @return Whether video is being captured.
      */
     private boolean isCapturingVideo() {
         return !mTab.isClosing() && nativeIsCapturingVideo(mTab.getWebContents());
     }
 
+    /**
+     * @return Whether screen is being captured.
+     */
+    private boolean isCapturingScreen() {
+        return !mTab.isClosing() && nativeIsCapturingScreen(mTab.getWebContents());
+    }
+
+    /**
+     * When STOP button in the media capture notification is clicked, pass the event to native
+     * to stop the media capture.
+     **/
+    public static void notifyStopped(int tabId) {
+        if (sWebContentsMap.indexOfKey(tabId) >= 0) nativeNotifyStopped(sWebContentsMap.get(tabId));
+    }
+
     private static native void nativeOnRendererUnresponsive(WebContents webContents);
     private static native void nativeOnRendererResponsive(WebContents webContents);
     private static native boolean nativeIsCapturingAudio(WebContents webContents);
     private static native boolean nativeIsCapturingVideo(WebContents webContents);
+    private static native boolean nativeIsCapturingScreen(WebContents webContents);
+    private static native void nativeNotifyStopped(WebContents webContents);
 }