Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: Source/core/editing/FrameSelection.cpp

Issue 21235009: Make sure the last selection gets spell checked when focusing different frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1495 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 1506
1507 // Because RenderObject::selectionBackgroundColor() and 1507 // Because RenderObject::selectionBackgroundColor() and
1508 // RenderObject::selectionForegroundColor() check if the frame is active, 1508 // RenderObject::selectionForegroundColor() check if the frame is active,
1509 // we have to update places those colors were painted. 1509 // we have to update places those colors were painted.
1510 if (RenderView* view = m_frame->document()->renderView()) 1510 if (RenderView* view = m_frame->document()->renderView())
1511 view->repaintSelection(); 1511 view->repaintSelection();
1512 1512
1513 // Caret appears in the active frame. 1513 // Caret appears in the active frame.
1514 if (activeAndFocused) 1514 if (activeAndFocused)
1515 setSelectionFromNone(); 1515 setSelectionFromNone();
1516 else
1517 m_frame->editor()->spellCheckAfterBlur();
1516 setCaretVisibility(activeAndFocused ? Visible : Hidden); 1518 setCaretVisibility(activeAndFocused ? Visible : Hidden);
1517 1519
1518 // Update for caps lock state 1520 // Update for caps lock state
1519 m_frame->eventHandler()->capsLockStateMayHaveChanged(); 1521 m_frame->eventHandler()->capsLockStateMayHaveChanged();
1520 1522
1521 // Because StyleResolver::checkOneSelector() and 1523 // Because StyleResolver::checkOneSelector() and
1522 // RenderTheme::isFocused() check if the frame is active, we have to 1524 // RenderTheme::isFocused() check if the frame is active, we have to
1523 // update style and theme state that depended on those. 1525 // update style and theme state that depended on those.
1524 if (Element* element = m_frame->document()->focusedElement()) { 1526 if (Element* element = m_frame->document()->focusedElement()) {
1525 element->setNeedsStyleRecalc(); 1527 element->setNeedsStyleRecalc();
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
1918 sel.showTreeForThis(); 1920 sel.showTreeForThis();
1919 } 1921 }
1920 1922
1921 void showTree(const WebCore::FrameSelection* sel) 1923 void showTree(const WebCore::FrameSelection* sel)
1922 { 1924 {
1923 if (sel) 1925 if (sel)
1924 sel->showTreeForThis(); 1926 sel->showTreeForThis();
1925 } 1927 }
1926 1928
1927 #endif 1929 #endif
OLDNEW
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698