Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2123283007: [wasm] throw in case of assignment to module parameters (Closed)

Created:
4 years, 5 months ago by aseemgarg
Modified:
4 years, 5 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] throw in case of assignment to module parameters BUG=613928 R=bradnelson@chromium.org TEST=regress-613928.js Committed: https://crrev.com/8474f24450a95cac36ef486e4c4d603fb86ceede Cr-Commit-Position: refs/heads/master@{#37653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/asmjs/typing-asm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-613928.js View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
aseemgarg
4 years, 5 months ago (2016-07-07 22:53:13 UTC) #1
bradnelson
lgtm
4 years, 5 months ago (2016-07-11 17:16:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123283007/1
4 years, 5 months ago (2016-07-11 17:16:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 17:38:45 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 17:41:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8474f24450a95cac36ef486e4c4d603fb86ceede
Cr-Commit-Position: refs/heads/master@{#37653}

Powered by Google App Engine
This is Rietveld 408576698