Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 21205007: [rAc Android] Remove the old dialog implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 4c4d6526fd0546c348448188592a1b086e849202..5150507eb9783f8466b5faa6b4e8348d26ff51eb 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -465,6 +465,7 @@ AutofillDialogControllerImpl::~AutofillDialogControllerImpl() {
}
}
+#if !defined(OS_ANDROID)
Dan Beam 2013/08/01 19:23:53 ^ why are any of these files compiled on android a
aruslan 2013/08/01 19:34:33 Because TabAutofillManagerDelegate depends on Auto
// static
base::WeakPtr<AutofillDialogControllerImpl>
AutofillDialogControllerImpl::Create(
@@ -483,6 +484,7 @@ base::WeakPtr<AutofillDialogControllerImpl>
callback);
return autofill_dialog_controller->weak_ptr_factory_.GetWeakPtr();
}
+#endif // !defined(OS_ANDROID)
// static
void AutofillDialogControllerImpl::RegisterProfilePrefs(
@@ -1229,13 +1231,6 @@ ui::MenuModel* AutofillDialogControllerImpl::MenuModelForSection(
return NULL;
}
-#if defined(OS_ANDROID)
-ui::MenuModel* AutofillDialogControllerImpl::MenuModelForSectionHack(
- DialogSection section) {
- return SuggestionsMenuModelForSection(section);
-}
-#endif
-
ui::MenuModel* AutofillDialogControllerImpl::MenuModelForAccountChooser() {
// If there were unrecoverable Wallet errors, or if there are choices other
// than "Pay without the wallet", show the full menu.
@@ -2412,9 +2407,6 @@ void AutofillDialogControllerImpl::LoadRiskFingerprintData() {
gfx::Rect window_bounds;
#if !defined(OS_ANDROID)
window_bounds = GetBaseWindowForWebContents(web_contents())->GetBounds();
-#else
- // TODO(dbeam): figure out the correct browser window size to pass along for
- // android.
#endif
PrefService* user_prefs = profile_->GetPrefs();
@@ -2452,8 +2444,6 @@ void AutofillDialogControllerImpl::OpenTabWithUrl(const GURL& url) {
content::PAGE_TRANSITION_AUTO_BOOKMARK);
params.disposition = NEW_FOREGROUND_TAB;
chrome::Navigate(&params);
-#else
- // TODO(estade): use TabModelList?
#endif
}
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.h ('k') | chrome/browser/ui/autofill/autofill_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698