Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 21205007: [rAc Android] Remove the old dialog implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 32d1383c2779b1a94df1cd7db5ac565f85d1f0ec..e4b8cb22f1f9e6d03b52d637f5be9f17ff17da27 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -464,6 +464,7 @@ AutofillDialogControllerImpl::~AutofillDialogControllerImpl() {
}
}
+#if !defined(OS_ANDROID)
// static
base::WeakPtr<AutofillDialogControllerImpl>
AutofillDialogControllerImpl::Create(
@@ -482,6 +483,7 @@ base::WeakPtr<AutofillDialogControllerImpl>
callback);
return autofill_dialog_controller->weak_ptr_factory_.GetWeakPtr();
}
+#endif // !defined(OS_ANDROID)
// static
void AutofillDialogControllerImpl::RegisterProfilePrefs(
@@ -1228,13 +1230,6 @@ ui::MenuModel* AutofillDialogControllerImpl::MenuModelForSection(
return NULL;
}
-#if defined(OS_ANDROID)
-ui::MenuModel* AutofillDialogControllerImpl::MenuModelForSectionHack(
- DialogSection section) {
- return SuggestionsMenuModelForSection(section);
-}
-#endif
-
ui::MenuModel* AutofillDialogControllerImpl::MenuModelForAccountChooser() {
// If there were unrecoverable Wallet errors, or if there are choices other
// than "Pay without the wallet", show the full menu.
@@ -2400,9 +2395,6 @@ void AutofillDialogControllerImpl::LoadRiskFingerprintData() {
gfx::Rect window_bounds;
#if !defined(OS_ANDROID)
window_bounds = GetBaseWindowForWebContents(web_contents())->GetBounds();
-#else
- // TODO(dbeam): figure out the correct browser window size to pass along for
- // android.
#endif
PrefService* user_prefs = profile_->GetPrefs();
@@ -2440,8 +2432,6 @@ void AutofillDialogControllerImpl::OpenTabWithUrl(const GURL& url) {
content::PAGE_TRANSITION_AUTO_BOOKMARK);
params.disposition = NEW_FOREGROUND_TAB;
chrome::Navigate(&params);
-#else
- // TODO(estade): use TabModelList?
#endif
}
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.h ('k') | chrome/browser/ui/autofill/autofill_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698