Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21205007: [rAc Android] Remove the old dialog implementation. (Closed)

Created:
7 years, 4 months ago by aruslan
Modified:
7 years, 4 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAc Android] Remove the old dialog implementation. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215852

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4398 lines) Patch
D chrome/android/java/res/layout/autofill_dialog_content.xml View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/android/java/res/layout/autofill_dialog_title.xml View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/android/java/res/layout/autofill_editing_layout_credit_card.xml View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/android/java/res/layout/autofill_editing_layout_email.xml View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/java/res/layout/autofill_editing_layout_shipping.xml View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/android/java/res/layout/autofill_editing_spinner_item.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/android/java/res/layout/autofill_general_layout.xml View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/android/java/res/layout/autofill_menu_item.xml View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/android/java/res/layout/autofill_simple_menu_item.xml View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/android/java/res/values-land/dimens.xml View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java View 1 chunk +0 lines, -822 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogAccountHelper.java View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogConstants.java View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogField.java View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogFieldError.java View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogGlue.java View 1 chunk +0 lines, -439 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogMenuItem.java View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogNotification.java View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java View 1 chunk +0 lines, -248 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogView.java View 1 chunk +0 lines, -743 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/android/autofill/autofill_dialog_view_android.h View 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc View 1 chunk +0 lines, -865 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller.h View 1 chunk +0 lines, -6 lines 0 comments Download
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 5 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 2 chunks +5 lines, -0 lines 0 comments Download
chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
aruslan
PTAL, thanks!
7 years, 4 months ago (2013-07-31 02:31:01 UTC) #1
aruslan
7 years, 4 months ago (2013-07-31 02:35:54 UTC) #2
aruslan
7 years, 4 months ago (2013-08-01 17:32:46 UTC) #3
Dan Beam
https://chromiumcodereview.appspot.com/21205007/diff/4001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/21205007/diff/4001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode468 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:468: #if !defined(OS_ANDROID) ^ why are any of these files ...
7 years, 4 months ago (2013-08-01 19:23:53 UTC) #4
aruslan
On 2013/08/01 19:23:53, Dan Beam wrote: > https://chromiumcodereview.appspot.com/21205007/diff/4001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc > File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): > > https://chromiumcodereview.appspot.com/21205007/diff/4001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode468 ...
7 years, 4 months ago (2013-08-01 19:29:22 UTC) #5
aruslan
https://chromiumcodereview.appspot.com/21205007/diff/4001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/21205007/diff/4001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode468 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:468: #if !defined(OS_ANDROID) On 2013/08/01 19:23:53, Dan Beam wrote: > ...
7 years, 4 months ago (2013-08-01 19:34:33 UTC) #6
aruslan
Ping :) Let's remove the old dialog implementation!
7 years, 4 months ago (2013-08-02 17:33:39 UTC) #7
aruslan
Evan -- turned out I'll need your approval anyway, so please take a look, thanks!
7 years, 4 months ago (2013-08-02 21:44:28 UTC) #8
aruslan
Yusuf -- PTAL at Android changes, thanks!
7 years, 4 months ago (2013-08-02 21:56:33 UTC) #9
Yusuf
On 2013/08/02 21:56:33, aruslan wrote: > Yusuf -- PTAL at Android changes, thanks! lgtm
7 years, 4 months ago (2013-08-05 17:25:11 UTC) #10
aruslan
On 2013/08/05 17:25:11, Yusuf wrote: > On 2013/08/02 21:56:33, aruslan wrote: > > Yusuf -- ...
7 years, 4 months ago (2013-08-05 18:03:14 UTC) #11
Evan Stade
lgtm
7 years, 4 months ago (2013-08-05 20:56:54 UTC) #12
aruslan
On 2013/08/05 20:56:54, Evan Stade wrote: > lgtm Thanks!
7 years, 4 months ago (2013-08-05 20:57:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/21205007/18001
7 years, 4 months ago (2013-08-05 21:18:33 UTC) #14
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=18848
7 years, 4 months ago (2013-08-05 21:35:56 UTC) #15
aruslan
Ted, PTAL and apply the real seal of approval if appropriate, thanks!
7 years, 4 months ago (2013-08-05 22:14:43 UTC) #16
Ted C
On 2013/08/05 22:14:43, aruslan wrote: > Ted, PTAL and apply the real seal of approval ...
7 years, 4 months ago (2013-08-05 22:16:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/21205007/18001
7 years, 4 months ago (2013-08-05 22:18:06 UTC) #18
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 08:26:21 UTC) #19
Message was sent while issue was closed. 
Change committed as 215852

Powered by Google App Engine
This is Rietveld 408576698