Move simple png encoding for image_diff into tools/

Move simple png encoding for image_diff into tools/

Now that Blink isn't including webkit_support_gfx directly, this moves
it to live next to its only user (the image_diff tool).

R=dpranke
TBR=joth (for android_webview/tools/third_party_files_whitelist.txt)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215798

[Dirk Pranke, 2013-07-30 19:37:04]

lgtm assuming you fix the #ifdef guard.

https://codereview.chromium.org/21202003/diff/1/tools/imagediff/image_diff_png.h
File tools/imagediff/image_diff_png.h (right):

https://codereview.chromium.org/21202003/diff/1/tools/imagediff/image_diff_pn...
tools/imagediff/image_diff_png.h:6: #define
TOOLS_IMAGEDIFF_WEBKIT_SUPPORT_GFX_H_
#ifdef guard is wrong.

[jamesr, 2013-08-01 20:57:42]

FYI, there's some funkiness with content_shell that I missed initially need to
sort out before landing.  This patch isn't quite ready yet...

[jamesr, 2013-08-01 21:54:50]

OK, this fixes content_shell too

jochen@ - could you review the content/shell/webkit_test_controller.cc?  The
change is to use ui/gfx/ to do the png encoding instead of webkit_support_gfx

brettw@ - could you stamp the DEPS changes? i'm moving some code that directly
uses libpng, so the third_party/libpng DEPS rules move with it

dpranke@ - this is the same patch for tools/ and webkit/, except I've removed
the Encode...WithChecksum stuff from tools/imagediff/ since only content_shell
needs to know how to do that and it uses ui/gfx's encoder

[jochen (gone - plz use gerrit), 2013-08-01 21:56:42]

lgtm

[brettw, 2013-08-06 00:03:14]

lgtm

[jamesr, 2013-08-06 01:44:43]

tbr=joth for the android_webview/tools/third_party_files_whitelist.txt update

[commit-bot: I haz the power, 2013-08-06 01:48:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/21202003/19001

[commit-bot: I haz the power, 2013-08-06 05:32:06]

Change committed as 215798