Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: runtime/observatory/lib/src/elements/script_inset.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted vm-connect Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/script_inset.dart
diff --git a/runtime/observatory/lib/src/elements/script_inset.dart b/runtime/observatory/lib/src/elements/script_inset.dart
index 5776bc4e26f09725aaebdc4d390468b38fccdf29..bd2ceaf83ca13cd44d752b02459e4bf9716b5152 100644
--- a/runtime/observatory/lib/src/elements/script_inset.dart
+++ b/runtime/observatory/lib/src/elements/script_inset.dart
@@ -8,8 +8,7 @@ import 'dart:async';
import 'dart:html';
import 'dart:math';
import 'observatory_element.dart';
-import 'nav_bar.dart';
-import 'service_ref.dart';
+import 'any_service_ref_wrapper.dart';
import 'package:observatory/service.dart';
import 'package:observatory/utils.dart';
import 'package:polymer/polymer.dart';
@@ -99,7 +98,7 @@ abstract class Annotation implements Comparable<Annotation> {
}
Element serviceRef(object) {
- AnyServiceRefElement e = new Element.tag("any-service-ref");
+ AnyServiceRefElementWrapper e = new Element.tag("any-service-ref");
e.ref = object;
return e;
}
@@ -984,7 +983,8 @@ class ScriptInsetElement extends ObservatoryElement {
return 5;
}
const padding = 5;
- const navbarHeight = NavBarElement.height;
+ // TODO (cbernaschina) check if this is needed.
+ const navbarHeight = 40;
var rect = getBoundingClientRect();
var buttonHeight = element.clientHeight;
return min(max(0, navbarHeight - rect.top) + padding,
« no previous file with comments | « runtime/observatory/lib/src/elements/ports.html ('k') | runtime/observatory/lib/src/elements/script_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698