Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: runtime/observatory/lib/src/elements/nav/vm_menu.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted vm-connect Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/nav/vm_menu.dart
diff --git a/runtime/observatory/lib/src/elements/nav/vm_menu.dart b/runtime/observatory/lib/src/elements/nav/vm_menu.dart
new file mode 100644
index 0000000000000000000000000000000000000000..190a129b5486fd2fb282b003d7fea4e2027c173a
--- /dev/null
+++ b/runtime/observatory/lib/src/elements/nav/vm_menu.dart
@@ -0,0 +1,101 @@
+// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:html';
+import 'dart:async';
+import 'package:observatory/models.dart' as M show VM, IsolateRef;
+import 'package:observatory/src/elements/helpers/tag.dart';
+import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
+import 'package:observatory/src/elements/nav/menu.dart';
+import 'package:observatory/src/elements/nav/menu_item.dart';
+
+class NavVMMenuElement extends HtmlElement implements Renderable {
+ static const tag = const Tag<NavVMMenuElement>('nav-vm-menu',
+ dependencies: const [NavMenuElement.tag,
+ NavMenuItemElement.tag]);
+
+ RenderingScheduler _r;
+
+ Stream<RenderedEvent<NavVMMenuElement>> get onRendered => _r.onRendered;
+
+ bool _last;
+ M.VM _vm;
+ bool get last => _last;
+ M.VM get vm => _vm;
+ set last(bool value) {
+ if (_last != value) {
+ _last = value;
+ _r.dirty();
+ } else {
+ _r.scheduleNotification();
+ }
+ }
+
+ factory NavVMMenuElement(M.VM vm, {bool last: false,
+ RenderingQueue queue}) {
+ assert(vm != null);
+ assert(last != null);
+ NavVMMenuElement e = document.createElement(tag.name);
+ e._r = new RenderingScheduler(e, queue: queue);
+ e._vm = vm;
+ e._last = last;
+ return e;
+ }
+
+ NavVMMenuElement.created() : super.created() { createShadowRoot(); }
+
+ @override
+ void attached() { super.attached(); _r.enable(); }
+
+ @override
+ void detached() {
+ super.detached(); _r.disable(notify: true);
+ shadowRoot.children = [];
+ }
+
+ void render() {
+ /// TODO(cbernaschina) restore the format '${name}@${target.networkAddress}'
+ shadowRoot.children = [
+ new NavMenuElement(vm.name, last: last, queue: _r.queue, link: '/vm')
+ ..children = (
+ _vm.isolates.map((M.IsolateRef isolate) {
+ return new NavMenuItemElement(isolate.name, queue: _r.queue,
+ link: '/inspect?isolateId=${Uri.encodeComponent(isolate.id)}');
+ }).toList()
+ ..add(new ContentElement())
+ )
+ ];
+ }
+}
+
+/*
+@CustomTag('vm-nav-menu')
+class VMNavMenuElement extends ObservatoryElement {
+ @published bool last = false;
+ @published VM vm;
+
+ String nameAndAddress(name, target) {
+ if (name != null && target != null) {
+ return '${name}@${target.networkAddress}';
+ } else {
+ return '<initializing>';
+ }
+ }
+
+ VMNavMenuElement.created() : super.created();
+}
+ */
+/*
+<polymer-element name="vm-nav-menu">
+ <template>
+ <nav-menu link="/vm" anchor="{{ nameAndAddress(vm.name, vm.target) }}" last="{{ last }}">
+ <template repeat="{{ isolate in vm.isolates }}">
+ <nav-menu-item link="{{ makeLink('/inspect', isolate) }}"
+ anchor="{{ isolate.name }}"></nav-menu-item>
+ </template>
+ <content></content>
+ </nav-menu>
+ </template>
+</polymer-element>
+*/

Powered by Google App Engine
This is Rietveld 408576698