Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted vm-connect Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/debugger.dart
diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart
index 61a8989d60b4dd1737a817f739e05a2b6f5fc4c5..0cabad378f4cd0bf490f43593798d790bfe9b534 100644
--- a/runtime/observatory/lib/src/elements/debugger.dart
+++ b/runtime/observatory/lib/src/elements/debugger.dart
@@ -8,8 +8,7 @@ import 'dart:async';
import 'dart:html';
import 'dart:math';
import 'observatory_element.dart';
-import 'nav_bar.dart';
-import 'package:observatory/app.dart';
+import 'package:observatory/repositories.dart';
import 'package:observatory/cli.dart';
import 'package:observatory/debugger.dart';
import 'package:observatory/service.dart';
@@ -1313,7 +1312,7 @@ class _ConsoleStreamPrinter {
// Tracks the state for an isolate debugging session.
class ObservatoryDebugger extends Debugger {
- final SettingsGroup settings = new SettingsGroup('debugger');
+ final SettingsRepository settings = new SettingsRepository('debugger');
RootCommand cmd;
DebuggerPageElement page;
DebuggerConsoleElement console;
@@ -2005,7 +2004,8 @@ class DebuggerPageElement extends ObservatoryElement {
var cmdDiv = $['commandDiv'];
// For now, force navbar height to 40px in the debugger.
- int navbarHeight = NavBarElement.height;
+ // TODO (cbernaschina) check if this is needed.
+ int navbarHeight = 40;
int splitterHeight = splitterDiv.clientHeight;
int cmdHeight = cmdDiv.clientHeight;
@@ -2255,7 +2255,8 @@ class DebuggerFrameElement extends ObservatoryElement {
if (varsDiv == null) {
return minTop;
}
- const navbarHeight = NavBarElement.height;
+ // TODO (cbernaschina) check if this is needed.
+ const navbarHeight = 40;
const bottomPad = 6;
var parent = varsDiv.parent.getBoundingClientRect();
var varsHeight = varsDiv.clientHeight;
« no previous file with comments | « runtime/observatory/lib/src/elements/curly_block_wrapper.dart ('k') | runtime/observatory/lib/src/elements/debugger.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698