Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: runtime/observatory/lib/src/elements/isolate_ref.dart

Issue 2119733003: Wrapping leaf nodes in non polymer elements (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Converted error-ref tag Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/isolate_ref.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_ref.dart b/runtime/observatory/lib/src/elements/isolate_ref.dart
index 730a4383800b11a6be12506e3f2a086943cafa42..cf8327f6c8167cf1279f240ed8afeed718d2406a 100644
--- a/runtime/observatory/lib/src/elements/isolate_ref.dart
+++ b/runtime/observatory/lib/src/elements/isolate_ref.dart
@@ -4,10 +4,58 @@
library isolate_ref_element;
-import 'package:polymer/polymer.dart';
-import 'service_ref.dart';
+import 'dart:html';
+import 'dart:async';
+import 'package:observatory/repositories.dart'
+ show IsolateRef, IsolateUpdateEvent;
+import 'package:observatory/src/elements/helpers/tag.dart';
+
+class IsolateRefElement extends HtmlElement {
+ static const tag = const Tag<IsolateRefElement>('isolate-ref-wrapped');
+
+ Stream<IsolateUpdateEvent> _updates;
+ StreamSubscription _updatesSubscription;
+ IsolateRef _isolate;
+
+ IsolateRef get isolate => _isolate;
+
+ factory IsolateRefElement(IsolateRef isolate,
+ Stream<IsolateUpdateEvent> updates) {
+ assert(isolate != null);
+ assert(updates != null);
+ IsolateRefElement e = document.createElement(tag.name);
+ e._isolate = isolate;
+ e._updates = updates;
+ return e;
+ }
-@CustomTag('isolate-ref')
-class IsolateRefElement extends ServiceRefElement {
IsolateRefElement.created() : super.created();
+
+ @override
+ void attached() {
+ super.attached();
+ assert(_isolate != null);
+ assert(_updates != null);
+ render();
+ _updatesSubscription = _updates
+ .where((IsolateUpdateEvent e) => e.isolate.id == isolate.id)
+ .listen((IsolateUpdateEvent e) { _isolate = e.isolate; render(); });
+ }
+
+ @override
+ void detached() {
+ super.detached();
+ assert(_updatesSubscription != null);
+ _updatesSubscription.cancel();
+ _updatesSubscription = null;
+ }
+
+ void render() {
+ children = [
+ new AnchorElement(href:
+ '#/inspect?isolateId=${Uri.encodeComponent(isolate.id)}')
+ ..text = 'Isolate ${isolate.number} (${isolate.name})'
+ ..classes = ['isolate-ref']
+ ];
+ }
}

Powered by Google App Engine
This is Rietveld 408576698