Change IME conversion status by focusing input element

ui/base/ime/win/imm32_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_IME_WIN_IMM32_MANAGER_H
 #define UI_BASE_IME_WIN_IMM32_MANAGER_H
 
 #include <windows.h>
 
 #include <string>
@@ skipping 59 matching lines @@
 //   only for inputting East-Asian language texts, but also the ones from
 //   tablets (on Windows XP Tablet PC Edition and Windows Vista), voice
 //   recognizers (e.g. ViaVoice and Microsoft Office), etc.
 //   We can disable TSF and CUAS in Windows XP Tablet PC Edition. On the other
 //   hand, we can NEVER disable either TSF or CUAS in Windows Vista, i.e.
 //   THIS CLASS IS NOT ONLY USED ON THE INPUT CONTEXTS OF EAST-ASIAN
 //   LANGUAGES BUT ALSO USED ON THE INPUT CONTEXTS OF ALL LANGUAGES.
 class UI_EXPORT IMM32Manager {
  public:
   IMM32Manager();
-  ~IMM32Manager();
+  virtual ~IMM32Manager();
 
   // Retrieves whether or not there is an ongoing composition.
-  bool is_composing() const { return is_composing_; }
+  virtual bool is_composing() const { return is_composing_; }

[jochen (gone - plz use gerrit), 2013/08/07 02:25:23]

i think it's enough to make the methods virtual which you're actually overriding
in the test.

[yoichio, 2013/08/07 03:33:55]

Done.

 
   // Retrieves the input language from Windows and update it.
   // Return values
   //   * true
   //     The given input language has IMEs.
   //   * false
   //     The given input language does not have IMEs.
-  bool SetInputLanguage();
+  virtual bool SetInputLanguage();
 
   // Creates the IME windows, and allocate required resources for them.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void CreateImeWindow(HWND window_handle);
+  virtual void CreateImeWindow(HWND window_handle);
 
   // Updates the style of the IME windows.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
   //   * message [in] (UINT)
   //   * wparam [in] (WPARAM)
   //   * lparam [in] (LPARAM)
   //     Represent the windows message of the caller.
   //     These parameters are used for verifying if this function is called
   //     in a handler function for WM_IME_SETCONTEXT messages because this
   //     function uses ::DefWindowProc() to update the style.
   //     A caller just has to pass the input parameters for the handler
   //     function without modifications.
   //   * handled [out] (BOOL*)
   //     Returns ::DefWindowProc() is really called in this function.
   //     PLEASE DO NOT CALL ::DefWindowProc() IF THIS VALUE IS TRUE!
   //     All the window styles set in this function are over-written when
   //     calling ::DefWindowProc() after returning this function.
   // Returns the value returned by DefWindowProc.
-  LRESULT SetImeWindowStyle(HWND window_handle, UINT message,
-                            WPARAM wparam, LPARAM lparam, BOOL* handled);
+  virtual LRESULT SetImeWindowStyle(HWND window_handle, UINT message,
+                                    WPARAM wparam, LPARAM lparam,
+                                    BOOL* handled);
 
   // Destroys the IME windows and all the resources attached to them.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void DestroyImeWindow(HWND window_handle);
+  virtual void DestroyImeWindow(HWND window_handle);
 
   // Updates the position of the IME windows.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void UpdateImeWindow(HWND window_handle);
+  virtual void UpdateImeWindow(HWND window_handle);
 
   // Cleans up the all resources attached to the given IMM32Manager object, and
   // reset its composition status.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void CleanupComposition(HWND window_handle);
+  virtual void CleanupComposition(HWND window_handle);
 
   // Resets the composition status.
   // Cancel the ongoing composition if it exists.
   // NOTE(hbono): This method does not release the allocated resources.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void ResetComposition(HWND window_handle);
+  virtual void ResetComposition(HWND window_handle);
 
   // Retrieves a composition result of the ongoing composition if it exists.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
   //   * lparam [in] (LPARAM)
   //     Specifies the updated members of the ongoing composition, and must be
   //     the same parameter of a WM_IME_COMPOSITION message handler.
   //     This parameter is used for checking if the ongoing composition has
   //     its result string,
   //   * result [out] (string16)
   //     Represents the object contains the composition result.
   // Return values
   //   * true
   //     The ongoing composition has a composition result.
   //   * false
   //     The ongoing composition does not have composition results.
   // Remarks
   //   This function is designed for being called from WM_IME_COMPOSITION
   //   message handlers.
-  bool GetResult(HWND window_handle, LPARAM lparam, string16* result);
+  virtual bool GetResult(HWND window_handle, LPARAM lparam, string16* result);
 
   // Retrieves the current composition status of the ongoing composition.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
   //   * lparam [in] (LPARAM)
   //     Specifies the updated members of the ongoing composition, and must be
   //     the same parameter of a WM_IME_COMPOSITION message handler.
   //     This parameter is used for checking if the ongoing composition has
   //     its result string,
   //   * composition [out] (Composition)
   //     Represents the struct contains the composition status.
   // Return values
   //   * true
   //     The status of the ongoing composition is updated.
   //   * false
   //     The status of the ongoing composition is not updated.
   // Remarks
   //   This function is designed for being called from WM_IME_COMPOSITION
   //   message handlers.
-  bool GetComposition(HWND window_handle, LPARAM lparam,
-                      CompositionText* composition);
+  virtual bool GetComposition(HWND window_handle, LPARAM lparam,
+                              CompositionText* composition);
 
   // Enables the IME attached to the given window, i.e. allows user-input
   // events to be dispatched to the IME.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
   //   * complete [in] (bool)
   //     Represents whether or not to complete the ongoing composition.
   //     + true
   //       After finishing the ongoing composition and close its IME windows,
   //       start another composition and display its IME windows to the given
   //       position.
   //     + false
   //       Just move the IME windows of the ongoing composition to the given
   //       position without finishing it.
-  void EnableIME(HWND window_handle);
+  virtual void EnableIME(HWND window_handle);
 
   // Disables the IME attached to the given window, i.e. prohibits any
   // user-input events from being dispatched to the IME.
   // In Chrome, this function is used when:
   //   * a renreder process sets its input focus to a password input.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void DisableIME(HWND window_handle);
+  virtual void DisableIME(HWND window_handle);
 
   // Cancels an ongoing composition of the IME attached to the given window.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
-  void CancelIME(HWND window_handle);
+  virtual void CancelIME(HWND window_handle);
 
   // Updates the caret position of the given window.
   // Parameters
   //   * window_handle [in] (HWND)
   //     Represents the window handle of the caller.
   //   * caret_rect [in] (const gfx::Rect&)
   //     Represent the rectangle of the input caret.
   //     This rectangle is used for controlling the positions of IME windows.
-  void UpdateCaretRect(HWND window_handle, const gfx::Rect& caret_rect);
+  virtual void UpdateCaretRect(HWND window_handle, const gfx::Rect& caret_rect);
 
   // Updates the setting whether we want IME to render composition text.
-  void SetUseCompositionWindow(bool use_composition_window);
+  virtual void SetUseCompositionWindow(bool use_composition_window);
 
   // Returns the current input language id.
-  LANGID input_language_id() const { return input_language_id_; }
+  virtual LANGID input_language_id() const { return input_language_id_; }
 
   // Returns BCP-47 tag name of the current input language.
-  std::string GetInputLanguageName() const;
+  virtual std::string GetInputLanguageName() const;
 
   // Returns the text direction of the current input language.
-  base::i18n::TextDirection GetTextDirection() const;
+  virtual base::i18n::TextDirection GetTextDirection() const;
 
   // Sets conversion status corresponding to |input_mode|.
-  void SetTextInputMode(HWND window_handle, TextInputMode input_mode);
+  virtual void SetTextInputMode(HWND window_handle, TextInputMode input_mode);
 
   // Helper functions ----------------------------------------------------------
 
   // Checks if there is any RTL keyboard layout installed in the system.
   static bool IsRTLKeyboardLayoutInstalled();
 
   // Checks if the user pressed both Ctrl and right or left Shift keys to
   // requrest to change the text direction and layout alignment explicitly.
   // Returns true if only a Ctrl key and a Shift key are down. The desired text
   // direction will be stored in |*direction|.
@@ skipping 66 matching lines @@
 
   // Indicates whether or not we want IME to render composition text.
   bool use_composition_window_;
 
   DISALLOW_COPY_AND_ASSIGN(IMM32Manager);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_IME_WIN_IMM32_MANAGER_H