Issue 21185005: Expose a constructor for WebCryptoAlgorithm.

Issue 21185005: Expose a constructor for WebCryptoAlgorithm. (Closed)

Created:
7 years, 4 months ago by eroman

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, eae+blinkwatch, dglazkov+blink, abarth-chromium, tommyw+watchlist_chromium.org, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Expose a constructor for WebCryptoAlgorithm. This allows unittests on the chromium-side to construct it. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155223

Patch Set 3 : Add a factory method instead of constructor #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	public/platform/WebCryptoAlgorithm.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://codereview.chromium.org/21185005/diff/3001/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp File Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp (right): https://codereview.chromium.org/21185005/diff/3001/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp#newcode106 Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp:106: You've got an extra blank line here. https://codereview.chromium.org/21185005/diff/3001/public/platform/WebCryptoAlgorithm.h File ...

7 years, 4 months ago (2013-07-31 00:46:51 UTC) #2

eroman

https://codereview.chromium.org/21185005/diff/3001/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp File Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp (right): https://codereview.chromium.org/21185005/diff/3001/Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp#newcode106 Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp:106: On 2013/07/31 00:46:51, abarth wrote: > You've got an ...

7 years, 4 months ago (2013-07-31 01:49:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/21185005/9001

7 years, 4 months ago (2013-07-31 01:54:41 UTC) #5

Message was sent while issue was closed.

Change committed as 155223

Expand Messages | Collapse Messages