Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 21174002: Allow defining custom navigation on a per-page basis. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed changes. Updating tab_switching measurement Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 84ca2c0483de4241387c37c0d4d9e752267dcfac..bf3552cc7fe39e90c629fc61b569675d9fb98832 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -20,6 +20,7 @@ from telemetry.page import page_filter as page_filter_module
from telemetry.page import page_measurement_results
from telemetry.page import page_runner_repeat
from telemetry.page import page_test
+from telemetry.page.actions import navigate
class _RunState(object):
@@ -129,20 +130,14 @@ class PageState(object):
This function will be called once per page before any actions are executed.
"""
- if page.is_file:
- filename = page.serving_dirs_and_file[1]
- target_side_url = tab.browser.http_server.UrlOf(filename)
- else:
- target_side_url = page.url
-
if test:
test.WillNavigateToPage(page, tab)
- tab.Navigate(target_side_url, page.script_to_evaluate_on_commit)
- if test:
+ test.RunNavigateSteps(page, tab)
test.DidNavigateToPage(page, tab)
-
- page.WaitToLoad(tab, 60)
- tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
+ else:
+ i = navigate.NavigateAction()
+ i.RunAction(page, tab, None)
+ page.WaitToLoad(tab, 60)
def CleanUpPage(self, page, tab):
if page.credentials and self._did_login:
« no previous file with comments | « tools/telemetry/telemetry/page/actions/navigate_unittest.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698