chrome/browser/safe_browsing/client_side_detection_host.h - Issue 21170004: Store and return urls instead of hosts for the malware IP matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 21170004: Store and return urls instead of hosts for the malware IP matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/browser_feature_extractor.cc ('K') | « chrome/browser/safe_browsing/browser_feature_extractor.cc ('k') | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | chrome/browser/safe_browsing/client_side_detection_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host.h

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.h b/chrome/browser/safe_browsing/client_side_detection_host.h

index 7f3e93ee4023c885598e5787a614f51f71e06da6..95436526ef23aa1ebcd67a65bacbed186f03a2f7 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host.h

+++ b/chrome/browser/safe_browsing/client_side_detection_host.h

@@ -79,7 +79,7 @@ class ClientSideDetectionHost : public content::WebContentsObserver,

void MalwareFeatureExtractionDone(scoped_ptr<ClientMalwareRequest> request);

// Update the entries in browse_info_->ips map.

- void UpdateIPHostMap(const std::string& ip, const std::string& host);

+ void UpdateIPUrlMap(const std::string& ip, const std::string& url);

// From NotificationObserver. Called when a notification comes in. This

// method is called in the UI thread.

@@ -131,8 +131,8 @@ class ClientSideDetectionHost : public content::WebContentsObserver,

// Max number of ips we save for each browse

static const int kMaxIPsPerBrowse;

- // Max number of hosts we report for each malware IP.

- static const int kMaxHostsPerIP;

+ // Max number of urls we report for each malware IP.

+ static const int kMaxUrlsPerIP;

base::WeakPtrFactory<ClientSideDetectionHost> weak_factory_;