Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: Source/core/html/InputType.cpp

Issue 21165005: Support author Shadow DOM for INPUT elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Test should work on Windows and Linux. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/forms/InputTypeView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/InputType.cpp
diff --git a/Source/core/html/InputType.cpp b/Source/core/html/InputType.cpp
index aa6d2540dc7273f6defcaa1891f218b548a8996e..8f41d58a17e87a2c0c2915a4b1ec4c0a78e4a19c 100644
--- a/Source/core/html/InputType.cpp
+++ b/Source/core/html/InputType.cpp
@@ -413,11 +413,11 @@ void InputType::destroyShadowSubtree()
root->removeChildren();
- // It's ok to clear contents of all other ShadowRoots because they must have
- // been created by InputFieldPasswordGeneratorButtonElement, and we don't allow adding
- // AuthorShadowRoot to HTMLInputElement.
- // FIXME: Remove the PasswordGeneratorButtonElement's shadow root and then remove this loop.
- while ((root = root->youngerShadowRoot())) {
+ // It's ok to clear contents of all other UA ShadowRoots because they must
+ // have been created by InputFieldPasswordGeneratorButtonElement.
+ // FIXME: Remove the PasswordGeneratorButtonElement's shadow root and then
+ // remove this loop.
+ while ((root = root->youngerShadowRoot()) && root->type() == ShadowRoot::UserAgentShadowRoot) {
root->removeChildren();
root->appendChild(HTMLShadowElement::create(shadowTag, element()->document()));
}
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/forms/InputTypeView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698